Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

READY : Fix to pass tests #87

Merged
merged 8 commits into from
Dec 22, 2020
Merged

READY : Fix to pass tests #87

merged 8 commits into from
Dec 22, 2020

Conversation

JackieJoo
Copy link
Contributor

@JackieJoo JackieJoo commented Dec 11, 2020 •
edited
Loading

Fixed :

  • Moved subroutines to the corresponding test routines( _output -> output, _input -> input, _finit -> finit ).
  • Uncommented code block for onWriteBegin callback in _writeToChannelWithoutExclusion routine in the 'ChainingMixin.s' file.
  • Fixed output test routine without last test group 'multiple original/exclusive output' ( 8 test cases, commented them ) - changed to use proper onWriteBegin & onWriteEnd callbacks.

Not fixed :

  • Sample 'ColorTable.ss'.
  • output test routine : test group 'multiple original/exclusive output' ( 8 test cases ).
  • colorConsoleDirectives test routine

@JackieJoo JackieJoo changed the title NOT READY : Fix to pass tests READY : Fix to pass tests Dec 17, 2020
@Wandalen Wandalen merged commit 4e82991 into Wandalen:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackieJoo @Wandalen