Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused files #8

Closed
wants to merge 1 commit into from
Closed

remove unused files #8

wants to merge 1 commit into from

Conversation

emar-kar
Copy link
Contributor

Exported functions from those files are not used, and I don't see the point of keeping them.
I suggest we can remove them for clean-up?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.21%. Comparing base (746577b) to head (5f371ed).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   24.77%   25.21%   +0.43%     
==========================================
  Files          26       22       -4     
  Lines         787      714      -73     
==========================================
- Hits          195      180      -15     
+ Misses        575      517      -58     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WangYihang
Copy link
Owner

Some of the function is not used due to the lack of examples, I will provide more examples illustrating these functions.

@emar-kar
Copy link
Contributor Author

I mean, what's the point of having them, if they are not actually part of the base functionality?

@emar-kar emar-kar closed this by deleting the head repository Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants