Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use actual types for private readonly fields #278

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Use actual types for private readonly fields #278

merged 1 commit into from
Mar 23, 2022

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Mar 23, 2022

Closes #271

A note on the change from:

_typeCache.Remove(type);

To:

_typeCache.TryRemove(type, out _);

The runtime uses this behavior too:

https://github.com/dotnet/runtime/blob/3ae87395f638a533f37b8e3385f6d3f199a72f4f/src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs#L1472

@Washi1337 Washi1337 added enhancement dotnet Issues related to AsmResolver.DotNet labels Mar 23, 2022
@Washi1337 Washi1337 added this to the 4.10.0 milestone Mar 23, 2022
@Washi1337 Washi1337 merged commit fb599dc into Washi1337:development Mar 23, 2022
@Washi1337
Copy link
Owner

Thanks a lot!

@ds5678
Copy link
Contributor Author

ds5678 commented Mar 23, 2022

You're welcome!

@ds5678 ds5678 deleted the feature/use_actual_types_for_private_readonly branch March 23, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Washi1337 Washi1337 Washi1337 approved these changes

Assignees
No one assigned
Labels
dotnet Issues related to AsmResolver.DotNet enhancement
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ds5678 @Washi1337