BUGFIX: EnC Metadata stream loading precedence #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Washi1337
added
bug
enhancement
pe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a slight difference in the loading process of metadata streams between normal and EnC metadata. EnC always selects the first heap with a provided name, while normal metadata prefers the last instead. While a normal .NET compiler only emits one stream per stream type, post-processed binaries (e.g., obfuscated binaries) may include duplicated streams to throw off disassemblers. Currently, the metadata loader always assumes the first stream to be the selected stream, meaning some binaries were not loaded properly by AsmResolver. This PR ensures that this difference is taken into account in
Metadata.GetStream,Metadata.TryGetStream, and throughout the entirety ofAsmResolver.DotNet, fixing this issue.References: