Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated examples #4

Merged
merged 10 commits into from
Jun 12, 2023

Conversation

apepkuss
Copy link
Collaborator

In this PR, the original examples in wasmedge-sdk are removed. Instead, wasmedge-rustsdk-examples repo provides the new examples.

Copy link
Member

juntao commented May 31, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


The pull request focuses on removing deprecated examples from the codebase and related workflows. There seem to be no potential problems with this change. The key changes are deleting example files and removing the corresponding code from the repository's other files, as well as updating the Rust bindings workflow and adding tests. A README file has been added to the examples folder that links to a separate repository that contains the examples. The changes appear to be safe and improve the workflow, but it would require further review of the entire pull request to ensure there are no issues with removing the examples.

Details

Commit 6950f6b8c2b229ff595c528d23c0054214c08f3b

The pull request removes several example files and associated code from the repository. The changes seem to be removing deprecated examples that are no longer needed. There seem to be no potential problems with this change. The key changes are deleting 10 example files and removing the corresponding code from 17 other files.

Commit f3fcb56be531c352a3c299214445a63868eff1f2

Key changes:

  • The workflow for bindings-rust has been updated.
  • The code related to deprecated examples has been removed from the workflow.

Potential problems:

  • There are no potential problems with this patch.

Commit 248a1d9c1eda95add21a083374a84045c3eb9026

The patch updates the workflow in the bindings-rust.yml file by commenting out the commands that build the wasi_print_env example and removing the examples directory. The changes were made to prevent conflicts with the deprecated examples that are being removed in another pull request.

A potential problem with the changes is that the wasi_print_env example is no longer being built and tested. If this example is used elsewhere in the project, any changes to its functionality may not be caught early on in the development process.

Commit 07410bca3d4d0c78eab6970bee2fde5abae1b80f

This patch removes the deprecated example folders from the Rust bindings workflow. Specifically, it deletes the references to the "examples/**" path in the YAML configuration file. This change updates the workflow to reflect the current state of the codebase with respect to examples, which might have been removed or intentionally deprecated. No potential problems have been identified in this patch. The only issue could be if someone still needs the examples, but this possibility is unlikely since they were labeled as deprecated and thus not recommended.

Commit 1c9c652b9edb3e3d69336024a62dc29bdf6ee728

Key changes:

  • A new README file has been added to the examples folder.
  • The README file provides a link to a separate repository that contains the examples.

Potential problems:

  • No potential problems have been identified in this patch. However, it would require further review of the entire pull request to ensure there are no issues with removing the deprecated examples.

Commit 8fa51dc6eff8704db24213e1cd4783ea6b6c40e3

The patch updates a GitHub workflow file that is used to test a Rust SDK with the Wasmedge toolchain in different environments. Specifically, the patch adds a new command to test the Rust SDK with the Wasmedge toolchain's wasmedge-sys library examples.

Potential problems are unlikely as this patch is simply adding new tests to the existing workflow, but it is still important to ensure that all the tests pass and that the workflow does not cause any runtime problems.

Commit 7f818ddce10ecfb83c5f408b57b7e462f70c3405

This patch updates the workflow for building the Rust bindings for WasmEdge. It removes the tests for examples and adds comments to disable them. The purpose seems to be to remove unnecessary testing, which is reasonable since the examples are deprecated.

There are no potential problems found in this patch.

Commit 098949c05083c4b1731f37733ab3c4ce458aea45

The patch updates the workflow configuration for Rust bindings. Specifically, it modifies the testing process to use cargo test instead of cargo test with commented-out code. The underlying job remains the same. The changes appear to be safe and improve the workflow. No potential problems have been identified.

Commit 195eb3bf960e24145e8516ec5380262ac2d1f50c

This patch updates the GitHub workflow file for Rust bindings to remove some deprecated examples. The removed examples are no longer used in the test suite. There seem to be no other changes.

No potential problems were identified.

Commit e674de1dcc073a559fd8a49898eaa7f83b12ac05

The pull request is a minor update to a GitHub workflow file "bindings-rust.yml". The change adds --exclude async-wasi argument to the cargo test commands for macOS and Windows jobs.

The purpose of the update appears to be to skip tests that use "async-wasi" feature, since it has been deprecated. The change should not cause any problems, but it could be useful to ensure that all other tests still pass.

Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss apepkuss force-pushed the refactor/remove-examples-new branch from 1b78c5f to 098949c Compare June 12, 2023 12:16
Signed-off-by: Xin Liu <sam@secondstate.io>
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss apepkuss marked this pull request as ready for review June 12, 2023 12:56
@apepkuss
Copy link
Collaborator Author

@L-jasmine Thanks for the review!

@apepkuss apepkuss merged commit cee68bb into WasmEdge:main Jun 12, 2023
@apepkuss apepkuss deleted the refactor/remove-examples-new branch June 12, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants