Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable timeout functionality when building for musl libc #71

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Disable timeout functionality when building for musl libc #71

merged 1 commit into from
Sep 22, 2023

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented Sep 22, 2023 •
edited
Loading

Fixes #70

@juntao Flows.network Integration
Copy link
Member

juntao commented Sep 22, 2023 •
edited
Loading

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

Commit ce8d109a9011bcd13fe503f3f928d7f40d9febcd

Key Changes:

  • The patch disables timeout functionality in the musl libc version.
  • The changes are made in the executor.rs, function.rs, and vm.rs files.

Potential Problems:

  • The patch disables timeout functionality specifically for the musl libc version of the code. This could result in longer execution times or potential hangs if there are issues with the code being executed.
  • The conditional compilation directives (cfg()) ensure that the changes are only applied when targeting the Linux operating system and not the musl libc environment. However, there is no explanation provided for why the timeout functionality is being disabled specifically for the musl libc version.
  • It would be helpful to include a justification or explanation in the commit message or PR description to provide context for why the timeout functionality is being disabled for musl libc.

@jprendes
disable timeout in musl libc
ce8d109 
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@jprendes
Copy link
Contributor Author

jprendes commented Sep 22, 2023 •
edited
Loading

@apepkuss , PTAL :-)
Also, can you please tag a minor release afterwards?

@jprendes jprendes mentioned this pull request Sep 22, 2023
Merged
@hydai hydai requested a review from apepkuss September 22, 2023 10:24
@apepkuss apepkuss merged commit ea83733 into WasmEdge:main Sep 22, 2023
34 checks passed
@juntao juntao mentioned this pull request Sep 22, 2023
Merged
L-jasmine pushed a commit to second-state/wasmedge-rust-sdk that referenced this pull request Nov 1, 2023
@jprendes @L-jasmine
Disable timeout in musl libc (WasmEdge#71)
db19c07 
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
L-jasmine pushed a commit to second-state/wasmedge-rust-sdk that referenced this pull request Nov 1, 2023
@jprendes @L-jasmine
Disable timeout in musl libc (WasmEdge#71)
7cfb547 
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: csh <458761603@qq.com>
apepkuss added a commit that referenced this pull request Nov 28, 2023
@L-jasmine @jprendes @apepkuss
Refactor RustSDK (#83)
9211bd7 
* [Refactor] Add #[form] for subtypes of WasmEdgeError.

Signed-off-by: csh <458761603@qq.com>

* [Refactor] fix memory leak

Signed-off-by: csh <458761603@qq.com>

* [Fix] Avoid the CPU 100% by tokio-wasi.

Signed-off-by: csh <458761603@qq.com>

* [Fix] Fix blocking during tokio-wasi TCP connect.

Signed-off-by: csh <458761603@qq.com>

* [Fix] async-wasi get envs & args

Signed-off-by: csh <458761603@qq.com>

* [Perf] Optimize the wasi-ctx

Signed-off-by: csh <458761603@qq.com>

* [Chore] Temporarily disable the serialize feature.

Signed-off-by: csh <458761603@qq.com>

* [feat] virtual file system

Signed-off-by: csh <458761603@qq.com>

* [Refactor] update the argument type of `run_func_with_timeout` and `run_func_async_with_timeout` (#76)

* [Feat] run func timeout use std::time::Duration

Signed-off-by: csh <458761603@qq.com>

* [Doc]: update api docs

Signed-off-by: csh <458761603@qq.com>

---------

Signed-off-by: csh <458761603@qq.com>
(cherry picked from commit 07e84b7)
Signed-off-by: csh <458761603@qq.com>

* [Refactor] delete useless code from validator

Signed-off-by: csh <458761603@qq.com>

* [Refactor] To pass the clippy

Signed-off-by: csh <458761603@qq.com>

* Disable timeout in musl libc (#71)

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: csh <458761603@qq.com>

* Disable timeout in musl libc

Signed-off-by: csh <458761603@qq.com>

* [Doc] update doc

Signed-off-by: csh <458761603@qq.com>

* [Fix] fix ffi::WasmEdge_String to String

Signed-off-by: csh <458761603@qq.com>

* [Fix] Fix unit test

Signed-off-by: csh <458761603@qq.com>

* [Fix] Modify the `WasiModule`.

Signed-off-by: csh <458761603@qq.com>

* [refactor] Introduce `WasmEdge_FunctionInstanceGetData` to drop host data (#84)

* feat(rust-sys): drop host_data in `Function::drop`

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update `drop` of `ImportModule` and `Function`

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sdk): update test code

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update `drop` of `ImportModule` and `Function`

Signed-off-by: Xin Liu <sam@secondstate.io>

* refactor(rust-sys): update `ImportModule::drop`

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): remove debug code

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sdk): remove debug code

Signed-off-by: Xin Liu <sam@secondstate.io>

* version(rust-sdk): bump to `0.13.0`

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): supress clippy warning

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci(ci-build): update rust version

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci(standalone): update rust version

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update rustdoc

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sdk): update rustdoc and `README`

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update dependencies

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci: update to `macos-13`

Signed-off-by: Xin Liu <sam@secondstate.io>

---------

Signed-off-by: Xin Liu <sam@secondstate.io>

* doc: update `CHANGELOG` (#85)

Signed-off-by: Xin Liu <sam@secondstate.io>

* [Chore] Update build script (#86)

* chore(rust-sys): update build script

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update build script

Signed-off-by: Xin Liu <sam@secondstate.io>

---------

Signed-off-by: Xin Liu <sam@secondstate.io>

* [Fix] Fix sys test

Signed-off-by: csh <458761603@qq.com>

* Relax the version of `wat` dep  (#90)

* chore(rust-sdk): update `wat` dep

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sdk): update test code

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update test code

Signed-off-by: Xin Liu <sam@secondstate.io>

* version(rust-sys): bump to `0.17.4`

Signed-off-by: Xin Liu <sam@secondstate.io>

* version(rust-sdk): bump to `0.13.1`

Signed-off-by: Xin Liu <sam@secondstate.io>

* doc: update `CHANGELOG`

Signed-off-by: Xin Liu <sam@secondstate.io>

---------

Signed-off-by: Xin Liu <sam@secondstate.io>

* [CI] skip test_vmbuilder on fedora

Signed-off-by: csh <458761603@qq.com>

* Fix static build to link agains zstd (#91)

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>

* Update doc for releasing `v0.13.2` (#93)

* ci: update workflows

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update versioning table

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sdk): update versioning table

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci(rust-static-lib): fix typo

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update rustdoc

Signed-off-by: Xin Liu <sam@secondstate.io>

* version(rust-sdk): bump to `0.13.2`

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sdk): update versioning table

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <sam@secondstate.io>

---------

Signed-off-by: Xin Liu <sam@secondstate.io>

* [Version] Bump `wasmedge-sys` to `v0.17.5` (#94)

* version(rust-sys): bump to `0.17.5`

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update versioning table

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sys): update dependency

Signed-off-by: Xin Liu <sam@secondstate.io>

* chore(rust-sdk): update versioning table

Signed-off-by: Xin Liu <sam@secondstate.io>

---------

Signed-off-by: Xin Liu <sam@secondstate.io>

* doc: update `CHANGELOG` (#95)

Signed-off-by: Xin Liu <sam@secondstate.io>

* [CI] Update `rust-static-lib` workflow (#96)

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci(rust-static-lib): update workflow

Signed-off-by: Xin Liu <sam@secondstate.io>

* ci(rust-static-lib): remove `libboost-all-dev` dep

Signed-off-by: Xin Liu <sam@secondstate.io>

---------

Signed-off-by: Xin Liu <sam@secondstate.io>

* [Fix] Temporary FuncRef extraction implementation.

Signed-off-by: csh <458761603@qq.com>

* [CI] fix test wat

Signed-off-by: csh <458761603@qq.com>

---------

Signed-off-by: csh <458761603@qq.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Xin Liu <sam@secondstate.io>
Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
Co-authored-by: Xin Liu <sam@secondstate.io>
@L-jasmine L-jasmine mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apepkuss apepkuss apepkuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure on alpine
3 participants
@jprendes @juntao @apepkuss