Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(walletkit): fix custom service provider #73

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

kevzzsk
Copy link
Member

@kevzzsk kevzzsk commented Feb 6, 2023

What this PR does / why we need it:

Fix custom service provider url not respected. This is probably caused when migration of common code into walletkit

Which issue(s) does this PR fixes?:

Fixes #3906

Additional comments?:

@github-actions github-actions bot added the kind/fix Fix a bug label Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 68.33% // Head: 65.76% // Decreases project coverage by -2.58% ⚠️

Coverage data is based on head (aca4c9d) compared to base (9c079d2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   68.33%   65.76%   -2.58%     
==========================================
  Files          20       21       +1     
  Lines         619      663      +44     
  Branches      112      119       +7     
==========================================
+ Hits          423      436      +13     
- Misses        187      218      +31     
  Partials        9        9              
Impacted Files Coverage Δ
packages/walletkit-core/src/api/whale.ts 100.00% <100.00%> (ø)
...ackages/walletkit-ui/src/contexts/WhaleContext.tsx 94.11% <100.00%> (+0.78%) ⬆️
...walletkit-ui/src/contexts/StoreServiceProvider.tsx 16.21% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom service provider url is not respected
2 participants