Password protect partnered events #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karbassi
reviewed
Sep 21, 2016
| @@ -25,7 +26,7 @@ | |||
| SECRET_KEY = 'e^u3u$pukt$s=6#&9oi9&jj5ow6563fuka%y9t7i*2laalk^l$' | |||
|
|
|||
| # SECURITY WARNING: don't run with debug turned on in production! | |||
| DEBUG = str_to_bool(os.environ.get('DEBUG')) or False | |||
| DEBUG = str_to_bool(os.environ.get('DEBUG')) and 'test' not in sys.argv or False | |||
There was a problem hiding this comment.
@ash6851 Can you explain what this addition does?
There was a problem hiding this comment.
@karbassi when I was writing tests I was trying to check response url, but the redirect was being intercepted by the redirect debug page and my response url was wrong. Let me know if you need more explanation
There was a problem hiding this comment.
@ash6851 ah, yes. This needs to be set to default to false. I'll commit a fix ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend code for #402. front end isn't pretty :)