-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to ignore URLs that match a prefix #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 🚀
Code Coverage Report
SwiftLint found issues
Generated by 🚫 Danger Swift against 6dfdbc3 |
Resolves #93.
Extend the Mocker's ignore rules to have an option to ignore any URLs that start with a specific prefix. This expands on existing functionality that has ignore rules for ignoring URLs that match exactly, or matching the URL excluding the query.
If this PR is approved, it may be nice to consider a follow-up PR to make a similar change to the
Mock
struct, migrating its use ofignoreQuery
to also use aURLMatchType
approach. If this is of interest to the repo maintainers, I could open an issue for further discussion, for example on how to deal the proliferation of public initializers as mentioned here #140 (comment)