Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create polish localization #221

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

lukszar
Copy link
Contributor

@lukszar lukszar commented Mar 6, 2020

Create translation file for polish language.

Create translation file for polish language.
@ghost
Copy link

ghost commented Mar 6, 2020

Messages
📖

View more details on Bitrise

📖 WeScan: Executed 56 tests, with 0 failures (0 unexpected) in 18.427 (18.599) seconds

Generated by 🚫 Danger Swift against 51e49f5

@AvdLee
Copy link
Contributor

AvdLee commented Mar 9, 2020

This is great, wielkie dzięki! 😃

Copy link
Contributor

@Boris-Em Boris-Em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@Boris-Em Boris-Em merged commit 72c5a75 into WeTransfer:master Mar 9, 2020
@AvdLee
Copy link
Contributor

AvdLee commented Mar 10, 2020

@lukszar we realized after merging that this change might not even work if we compare the changes to this PR that's adding Spanish translations: #223

Did you test your changes before committing?

@lukszar
Copy link
Contributor Author

lukszar commented Mar 10, 2020

To be honest I provided just translation strings and didn’t check if multi-language works in the end.

@lukszar
Copy link
Contributor Author

lukszar commented Mar 10, 2020

Does it means that translations are not working in WeScan at all?

@AvdLee
Copy link
Contributor

AvdLee commented Mar 10, 2020

Does it means that translations are not working in WeScan at all?

Well, they do! But we have to do a bit more than only adding a language file as you can see in this PR.

It's not a lot but we didn't do it in this PR. I haven't find the time to verify that it's actually not working though.

@lukszar
Copy link
Contributor Author

lukszar commented Mar 10, 2020

I updated Xcode project for new language. After all tested and it works. I created new PR #224

Hope everything will works this time.

@ghost
Copy link

ghost commented Mar 11, 2020

Congratulations! 🎉 This was released as part of Release 1.5.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants