Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SwiftUI Previews in Xcode >= 14 #338

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

amarildolucas
Copy link
Contributor

In Xcode >= 14 SwiftUI Previews don't work (successfully built) if WeScan package is in the project. The following error occur:

HumanReadableSwiftError

SettingsError: noExecutablePath(<IDESwiftPackageStaticLibraryProductBuildable:ObjectIdentifier(0x000080009ac3e880):'WeScan'>)

This PR fixed the current issue by removing the type: static parameter from the Package.swift.

Copy link
Contributor

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @amarildolucas!

@AvdLee
Copy link
Contributor

AvdLee commented Nov 3, 2022

@amarildolucas our repository requires signed commits. Would it be possible for you to enable signed commits and recommit using the following command:

 git rebase --exec 'git commit --amend --no-edit -n -S' master
  git push --force

You can read more about setting up signed commits here.

@amarildolucas
Copy link
Contributor Author

Hi @AvdLee, thanks for the feedback. I just signed the commit.

@AvdLee
Copy link
Contributor

AvdLee commented Nov 15, 2022

@amarildolucas FYI: I'm looking into fixing CI in another PR.

@wetransferplatform
Copy link
Collaborator

Warnings
⚠️ 'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0
⚠️ 'isAutoStillImageStabilizationEnabled' was deprecated in iOS 13.0
⚠️ 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
⚠️

'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)

⚠️ 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
⚠️ 'gray' was deprecated in iOS 13.0: renamed to 'UIActivityIndicatorView.Style.medium'
Messages
📖

View more details on Bitrise

📖 WeScanTests: Executed 56 tests (0 failed, 0 retried, 0 skipped) in 20.631 seconds

Code Coverage Report

Name Coverage
WeScan 37.45% ⚠️

Generated by 🚫 Danger Swift against 704a651

@AvdLee AvdLee merged commit 3f26445 into WeTransfer:master Dec 7, 2022
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 2.0.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants