-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support postgres #13
Support postgres #13
Conversation
This reverts commit 663260f.
@julik @lorenzograndi4 sorry I know this PR is huge! If you could just take a quick look, I would appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diagonal scan looks good 😆
Could it be an idea to try to install a "representative dataset" for testing the gem? For example using a fuller list of Brazilian municipalities + a longer list of people names, say generated with Faker. I suspect it is really dependent on the table size, both for MySQL and PostgerSQL, what the query planner will plan.
thank you! Indeed, I also think that the results would be better if using more data, but this will not be the case when it analyses queries running on unit tests, for example. I will create an issue with that, maybe an idea could be born influenced by that! |
related to #3
closes #11
This PR:
TestHelpers