Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i319] update notice styles #28

Merged
merged 2 commits into from
Jun 17, 2020
Merged

[i319] update notice styles #28

merged 2 commits into from
Jun 17, 2020

Conversation

pez-work
Copy link
Contributor

  • move to layouts patten
  • add dialog to block element reset
  • remove toast style and attach it to the toast component

Summary

Submitter Checklist:

  • Demo new or changed functionality to stakeholders
  • Perform self-review (see reviewer checklist)
  • Annotate MR with comments for reviewer
  • Document any new patterns or features on peak-design-system
  • Assign a team member who should specifically review this code
  • Address reviewer feedback, if any, and assign back to reviewer

Reviewer Checklist:

  • Version bump in package.json
  • Visually review significant UI changes
  • Assign @pez-wb as reviewer if needed
  • Assign back to submitter with feedback

- move to layouts patten
- add dialog to block element reset
- remove toast style and attach it to the toast component
@pez-work pez-work merged commit 2080764 into master Jun 17, 2020
@pez-work pez-work deleted the i319.notices branch June 17, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants