-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i304] Rename media-box to post #36
Conversation
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@wealthbar/peak-style", | |||
"version": "1.7.6", | |||
"version": "1.7.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this was necessary. I also bumped the version number in the peak docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure it is necessary, because it's an NPM package and I don't think NPM wants you to publish the same version twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is why the build errors are happening. you best bet is to keep this at the latest version until the peak-style
branch w/ your updates have been merged and deployed.
Until then just make a note in the PR description that it relies on a yarn link
to your peak-style branch (include PR link).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong PR for my comment — should apply to the PDS "@wealthbar/peak-style"
dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some cleanup suggestions
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@wealthbar/peak-style", | |||
"version": "1.7.6", | |||
"version": "1.7.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is why the build errors are happening. you best bet is to keep this at the latest version until the peak-style
branch w/ your updates have been merged and deployed.
Until then just make a note in the PR description that it relies on a yarn link
to your peak-style branch (include PR link).
Summary
Submitter Checklist:
Reviewer Checklist: