Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] card modal view #55

Merged
merged 5 commits into from
Sep 30, 2020
Merged

[Fix] card modal view #55

merged 5 commits into from
Sep 30, 2020

Conversation

pez-work
Copy link
Contributor

@pez-work pez-work commented Sep 9, 2020

Summary

Submitter Checklist:

  • Demo new or changed functionality to stakeholders
  • Perform self-review (see reviewer checklist)
  • Annotate MR with comments for reviewer
  • Document any new patterns or features on peak-design-system
  • Assign a team member who should specifically review this code
  • Address reviewer feedback, if any, and assign back to reviewer

Reviewer Checklist:

  • Version bump in package.json
  • Visually review significant UI changes
  • Assign @pez-wb as reviewer if needed
  • Assign back to submitter with feedback

justify-content: flex-end;
align-items: center;
flex-grow: 1;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have footer-previous? Or are 'previous' buttons always located at the top?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pattern is with the intention of serving the next -> button on workflows/steps. since the back button exists in the header I'm not sure it's necessary.


// -- Deprecation Warning

// card as a stand alone class for workflows will soon to be depricated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*deprecated

@pez-work pez-work merged commit e7b5098 into master Sep 30, 2020
@pez-work pez-work deleted the fix.card-modal-view branch September 30, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants