Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Updates: Casing, Monospacing, Modals #71

Merged
merged 5 commits into from
Dec 15, 2020

Conversation

travis-wb
Copy link
Contributor

Summary

Submitter Checklist:

  • Demo new or changed functionality to stakeholders
  • Perform self-review (see reviewer checklist)
  • Annotate MR with comments for reviewer
  • Document any new patterns or features on peak-design-system
  • Assign a team member who should specifically review this code
  • Address reviewer feedback, if any, and assign back to reviewer

Reviewer Checklist:

  • Version bump in package.json
  • Visually review significant UI changes
  • Assign @pez-wb as reviewer if needed
  • Assign back to submitter with feedback

@travis-wb travis-wb changed the title add styles for casing and monospacing Style Updates: Casing, Monospacing, Modals Dec 11, 2020
@@ -103,10 +103,12 @@ del, .neg {

.tab-numbers { font-feature-settings: $tab-numbers; }
.subtle { color: rgba($neutral-900, 0.77); }
.capitalize { text-transform: capitalize; }
.sentence-case:first-letter{ text-transform: capitalize; }
.title-case, .capitalize { text-transform: capitalize; }
.uppercase { text-transform: uppercase; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if uppercaseshould also include upper-case to match w/ classing convention of sentence-case and title-case

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@wealthbar/peak-style",
"version": "3.0.1",
"version": "3.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would argue that is is probably a patch (class additions/cleanup) vs a minor revision so 3.0.2

@travis-wb travis-wb merged commit 5e6a543 into master Dec 15, 2020
@travis-wb travis-wb deleted the add-casing-and-monospacing branch December 15, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants