-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Updates: Casing, Monospacing, Modals #71
Conversation
scss/base/typography.scss
Outdated
@@ -103,10 +103,12 @@ del, .neg { | |||
|
|||
.tab-numbers { font-feature-settings: $tab-numbers; } | |||
.subtle { color: rgba($neutral-900, 0.77); } | |||
.capitalize { text-transform: capitalize; } | |||
.sentence-case:first-letter{ text-transform: capitalize; } | |||
.title-case, .capitalize { text-transform: capitalize; } | |||
.uppercase { text-transform: uppercase; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if uppercase
should also include upper-case
to match w/ classing convention of sentence-case
and title-case
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@wealthbar/peak-style", | |||
"version": "3.0.1", | |||
"version": "3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would argue that is is probably a patch (class additions/cleanup) vs a minor revision so 3.0.2
Summary
Submitter Checklist:
Reviewer Checklist: