Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update more sections and add component button #58

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Update more sections and add component button #58

merged 6 commits into from
Dec 11, 2023

Conversation

dangthang1903
Copy link
Contributor

No description provided.

Copy link
Member

@hta218 hta218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update bro!
Please also make these changes:

  • Add a config group to Theme Settings to set the global config for Buttons (Use Buttons as the group name)
  • Add color settings for 3 styles of Buttons
  • Make your button component use colors from the Theme Settings

app/sections/CountDown/ButtonItems.tsx Outdated Show resolved Hide resolved
app/sections/PromotionGrid/ButtonItems.tsx Outdated Show resolved Hide resolved
app/sections/shared/Button.tsx Outdated Show resolved Hide resolved
app/sections/shared/Button.tsx Outdated Show resolved Hide resolved
@hta218
Copy link
Member

hta218 commented Dec 7, 2023

Any progress on this @dangthang1903 ?

@dangthang1903
Copy link
Contributor Author

em update lại anh check giúp em ạ

@hta218 hta218 merged commit 57b8639 into dev Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants