-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine Dev.to API with Single Post UI #217
Conversation
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I switched server-side rendering to client-side rendering as the app was built to hit Dev.to API rate limit. There might be a way to avoid hitting the limit while using server-side rendering, but CSR works fine here. |
Had a good look at this today. I was not able to find any information about dev.to API limit What worked for me was to remove the part which fetch the user details (maybe they don't want you to use multiple endpoints too soon after another) We could just have all the author's bio locally in I think we should use ISR, instead of client side rendering if possible, since the pages are crawlable which means better for SEO and also it's faster than client side rendering for the user ========================== With the functionalities, there are a few things I noticed,
|
It's a bit of work to hard coding but I think not many new people join and write a blog. I will take this path.
Dev to account doesn't hold a LinkedIn account. That's why getting redirected to the WDP account as a fallback. I can use local data to put the individual account links. |
UpdatesAt first, I was making a call to get user data from Dev.to API as post data does't include user summary. @cherylli found that this call caused the error, and she advised me to copy the summary to our local member data and use them instead of making an extra API call. Additionally, after this, I implemented a related/latest posts feature. Another Issue I found"Tips for collaborating with a new project codebase" has a styling issue and I'm unsure how to fix it. Need to update styling here |
I see the card has a pointer now but nothing happens when I clicked on it. |
Are you talking about this?
If so, I think this is out of the scope in this PR. |
Co-authored-by: Cheryl M <webmaster@cherylli.com>
Thanks for the review and guidance!! @cherylli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job, @Satoshi-Sh ! 🚀 🥇
close #216
Have you updated the CHANGELOG.md file? If not, please do it.
Yes.
What is this change?
Were there any complications while making this change?
I didn't know how the getStaticPaths and getStaticProps functions work in Next.js. It was confusing at first.
How to replicate the issue?
N.A.
If necessary, please describe how to test the new feature or fix.
Please go check individual blog post from the blog page.
When should this be merged?
After reviews.
Screenshots
P.S.
This part will be implemented after this PR?