-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding UnderscoreMappingResolver #114
Conversation
return Regex.Replace(propertyName, "([A-Z])([A-Z][a-z])|([a-z0-9])([A-Z])", "$1$3_$2$4", RegexOptions.Compiled).ToLower(); | ||
} | ||
|
||
public static readonly IEnumerable<MediaTypeFormatter> Formatters = new[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of this public field?
Thank you, left a comment in the code. |
The usual usage of this is class is like this:
So I cached it there. But now I start thinking this actually isn't a good idea. |
I updated code (removed that field), also updated test. |
makes sense. Thanks! |
Adding UnderscoreMappingResolver
Awesome, thanks! Any plans to push mater to nuget, please? |
ping @ChrisMissal |
There were no new releases for more than a year. I'd bump the minor version, i.e. By the way, way not |
Let's bump to 2.0. That will keep us on par with several of our other packages, as well as Web API. |
Ah! Sorry all, I'll get to this later today, I promise. |
Hey @ChrisMissal, any news, please? |
There are some issues with the build, CI, and NuGet packaging. I need to get with @panesofglass to see where we sit with some of the build scripts. We talked about it briefly, but we'll need to sync up again. I'll update this issue with what's going on when we're all on the same page. |
No description provided.