Fuzzer: When nested under makeTrivial(), avoid normal make() #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Apr 12, 2023
| @@ -1212,6 +1216,14 @@ Expression* TranslateToFuzzReader::_makeunreachable() { | |||
| } | |||
|
|
|||
| Expression* TranslateToFuzzReader::makeTrivial(Type type) { | |||
| struct TrivialNester { | |||
There was a problem hiding this comment.
This is an unfortunate amount of boilerplate just to run trivialNesting-- to run at scope exit, but I couldn't find a better way to do it outside of boost.
There was a problem hiding this comment.
Yeah... other languages can do better, e.g. defer in Go and Zig.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…mbly#5657) Without this, in certain complex operations we could end up calling a nested make() operation that included nontrivial things, which could cause problems. The specific problem I encountered was in fixAfterChanges() we tried to fix up a duplicate label, but calling makeTrivial() emitted something very large that happened to include a new block with a new label nested under a struct.get, and that block's label conflicted with a label we'd already processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, in certain complex operations we could end up calling a nested
make()operation that included nontrivial things, which could cause problems.The specific problem I encountered was in
fixAfterChanges()we tried to fix upa duplicate label, but calling
makeTrivial()emitted something very large thathappened to include a new block with a new label nested under a
struct.get,and that block's label conflicted with a label we'd already processed.