-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prose for basic struct/array instructions #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comments
document/core/exec/instructions.rst
Outdated
|
||
6. Pop the :math:`n` values :math:`\val^\ast` from the stack. | ||
|
||
8. For every value :math:`\val_i` in :math:`\val^\ast`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipped number 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
document/core/exec/instructions.rst
Outdated
|
||
17. For each consecutive subsequence :math:`{b'}^n` of :math:`b^\ast`: | ||
|
||
a. Let :math:`k_i` be the integer for which :math:`\bytes_{\X{ft}}(k_i)` is :math:`{b'}^n`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work even if t
is a floating point type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "constant"; also adjusted metavariable to c
.
document/core/exec/instructions.rst
Outdated
|
||
a. Trap. | ||
|
||
12. Let :math:`\fieldval` be the :ref:`field value <syntax-fieldval>` :math:`S.\SARRAYS[a].\AIFIELDS[i]`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Count should resume at 14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Co-authored-by: Thomas Lively <tlively@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thorough review!
document/core/exec/instructions.rst
Outdated
|
||
6. Pop the :math:`n` values :math:`\val^\ast` from the stack. | ||
|
||
8. For every value :math:`\val_i` in :math:`\val^\ast`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
document/core/exec/instructions.rst
Outdated
|
||
17. For each consecutive subsequence :math:`{b'}^n` of :math:`b^\ast`: | ||
|
||
a. Let :math:`k_i` be the integer for which :math:`\bytes_{\X{ft}}(k_i)` is :math:`{b'}^n`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "constant"; also adjusted metavariable to c
.
document/core/exec/instructions.rst
Outdated
|
||
a. Trap. | ||
|
||
12. Let :math:`\fieldval` be the :ref:`field value <syntax-fieldval>` :math:`S.\SARRAYS[a].\AIFIELDS[i]`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Leaving out type unrolling for now, since that's defined in #377.