-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multiple-return-type support #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewagner
force-pushed
the
single-return-type
branch
from
September 9, 2015 19:13
f330e59
to
6f15b4a
Compare
lukewagner
force-pushed
the
single-return-type
branch
3 times, most recently
from
September 10, 2015 04:13
40086ab
to
1645c20
Compare
lukewagner
force-pushed
the
single-return-type
branch
from
September 10, 2015 15:50
1645c20
to
dc582c3
Compare
@rossberg-chromium Thanks! Fixed everything except where prevented by the two issues noteda bove. |
Great, agreed and addressed all comments. |
lukewagner
added a commit
that referenced
this pull request
Sep 14, 2015
Remove multiple-return-type support
Merging based on LGTM |
ghost
mentioned this pull request
Apr 13, 2016
littledan
pushed a commit
to littledan/spec
that referenced
this pull request
Mar 4, 2018
In section "Initializing Memory Only Once" the WebAssembly.instantiate is missing a paren.
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Sep 18, 2019
…bAssembly#53) * Adjust element segment encoding to match the bulk-memory proposal * Update interpreter/binary/encode.ml Co-Authored-By: Andreas Rossberg <rossberg@mpi-sws.org> * Address comments
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
rossberg
added a commit
that referenced
this pull request
Jul 3, 2024
Add missing memory specifier to memory.init execution semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #15, this patch changes expression types from type lists to single types. Since some expressions don't return anything (e.g.,
break
),expr_type = value_type option
, as suggested in #15.