Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction to WABT #111

Merged
merged 4 commits into from
Sep 27, 2016
Merged

Introduction to WABT #111

merged 4 commits into from
Sep 27, 2016

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Sep 26, 2016

Introduces the name change from "sexpr-wasm-prototype" to WABT in
README.md but does not yet change all the URL references or code
references.

Introduces the name change from "sexpr-wasm-prototype" to WABT in
README.md but does not yet change all the URL references or code
references.
@dschuff
Copy link
Member Author

dschuff commented Sep 26, 2016

I figured it'd be better to wait to change the code until after 0xc lands, and change URL references until we change the repo name (presumably we do want to do that?)

@dschuff
Copy link
Member Author

dschuff commented Sep 26, 2016

(oh also you'll notice that I'm proposing that WABT be the way we spell the name in text, rather than "wabbit").

@dschuff
Copy link
Member Author

dschuff commented Sep 26, 2016

Implements part of #101

@sbc100
Copy link
Member

sbc100 commented Sep 26, 2016

I like the spelling.

@binji
Copy link
Member

binji commented Sep 26, 2016

lgtm, I guess I figured it would be fine to rename the repo first, because GH automatically redirects anyway. But we can wait and do it after 0xc lands instead.

@dschuff
Copy link
Member Author

dschuff commented Sep 26, 2016

Oh, I didn't realize that GH will redirect the URLs. I guess it doesn't really matter. Anyway this is pretty independent and can go in whenever. Is renaming the repo something that you can do? Or do we have to get one of the admins to do it?

@dschuff
Copy link
Member Author

dschuff commented Sep 26, 2016

wrt 0xc I was mostly concerned about conflicts in the code but there's actually not mention of sexpr-anything in there anyway. So yeah let's just rename the repo and I'll update the rest of README.md in this PR.

@binji
Copy link
Member

binji commented Sep 26, 2016

Pretty sure it redirects... maybe? :)
And yeah, I can't rename but I think @s3ththompson can.

@s3ththompson
Copy link
Member

Yes repo URLs as well as git requests all redirect from previous location. Let me know explicitly whenever you're ready to change and I'll rename!

(As an aside, I have a minor preference for keeping wabt lowercase in (just) the repo name given GitHub naming trends, but that's a minor detail)

@dschuff
Copy link
Member Author

dschuff commented Sep 26, 2016

I'm ready whenever @binji is :) lowercase wabt is fine for the repo name.

@binji
Copy link
Member

binji commented Sep 26, 2016

Yep, ready whenever. Shouldn't break anything. fingers crossed

@s3ththompson s3ththompson mentioned this pull request Sep 26, 2016
@s3ththompson
Copy link
Member

Done! Added some next steps in #101

@dschuff dschuff merged commit dd778ef into master Sep 27, 2016
@dschuff dschuff deleted the wabt branch September 27, 2016 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants