remove JavaScript engine testing #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,9 +1,6 @@ | |||
| [submodule "third_party/testsuite"] | |||
| path = third_party/testsuite | |||
| url = https://github.com/WebAssembly/testsuite | |||
| [submodule "third_party/v8/v8"] | |||
| path = third_party/v8/v8 | |||
| url = https://chromium.googlesource.com/v8/v8.git | |||
| [submodule "third_party/gtest"] | |||
There was a problem hiding this comment.
I don't fully understand the purpose of gtest.
It looks like it is used to build hexfloat_test, which I can't find what this is used for.
There was a problem hiding this comment.
My understanding is that older versions of MSVC (even 2013, I think?) don't support parsing hexadecimal floats via strtod. I implemented this (see wasm-literal.c), and wanted to add tests for it. hexfloat_test does exhaustive roundtrip testing of floats, and tests 4 billion doubles too. They don't run on Travis because they're kind of slow.
There was a problem hiding this comment.
I see, thanks for the clarification
|
This looks good to me, pretty much the same changes I made when testing on my side. |
binji
force-pushed
the
remove-javascript-testing
branch
from
b94e732
to
abb190c
Compare
It's not really the appropriate place to handle it. Now that we have wasm-wast and wasm-interp, we can at least verify that the tools are internally consistent.
binji
force-pushed
the
remove-javascript-testing
branch
from
abb190c
to
12625a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really the appropriate place to handle it. Now that we have
wasm-wast and wasm-interp, we can at least verify that the tools are
internally consistent.
Resolves #79.