Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basics implementation of <inttypes.h>. #16

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

sunfishcode
Copy link
Member

Musl's generic definitions for PRIxPTR and several others in
<inttypes.h> are incorrect for wasm, so introduce a new <inttypes.h>
and <__header_inttypes.h> in the basics module using compiler-provided
definitions.

Fixes #13.

Musl's generic definitions for PRIxPTR and several others in
<inttypes.h> are incorrect for wasm, so introduce a new <inttypes.h>
and <__header_inttypes.h> in the basics module using compiler-provided
definitions.

Fixes #13.
Copy link

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Is there a corresponding change to wasm32.rs in wasmtime, or were those types already correct?

@sunfishcode
Copy link
Member Author

The types were already correct; this is just fixing the PRI* and SCN* macros for printf and scanf.

@sunfishcode sunfishcode merged commit ad22a59 into master Apr 15, 2019
@sunfishcode sunfishcode deleted the inttypes branch April 15, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants