Fix #874: Construct ConvolverNode. #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2016 08:43
Add constructor and define the options dictionary.
| <code>disableNormalization</code>. | ||
| </dd> | ||
| <dt> | ||
| boolean disableNormalization = false |
There was a problem hiding this comment.
This is opposite in sense to an existing normalize attribute on a ConvolverNode. Is this intentional?
There was a problem hiding this comment.
Yes. I was following the suggestions and decisions made in #545 (comment) wrt to the boolean trap and why we used disableNormalization for the PeriodicWave dictionary.
|
cool. |
|
Assuming "cool" means lgtm, I'll fix up the AudioNodeChannelOptions name and merge this soon. Unless you object. |
It's AudioNodeOptions now, and added a link to the normalize attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constructor and define the options dictionary.