Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/WDSBT-12 - Mobile Menu #8

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Conversation

khleomix
Copy link
Contributor

@khleomix khleomix commented Apr 23, 2024

Closes

WDSBT-12

What type of PR is this? (put an x to all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Link to test

https://wdsbt.wdslab.com/

Description

  • Fix button outline variation issues
  • Cover block margin fixes
  • Add mobile menu styles

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Group-Block-.-WDSBT.mp4

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ Confluence
  • πŸ™… no documentation needed

Reviewer's Testing Checklist

As a reviewer, please ensure the following testing criteria are met and validated before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Accessibility Testing: Validate that the changes comply with accessibility standards.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint).
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Plugin Compatibility: Check if the changes are compatible with existing plugins and do not cause conflicts.
  • Core Functionality: Verify that the WordPress core functionalities are not disrupted.
  • Custom Post Types and Taxonomies: Confirm that any custom post types or taxonomies function as intended.
  • Security Best Practices: Ensure that the code follows WordPress security best practices.
  • Performance: Check for any performance issues, especially with database queries and page load times.
  • SEO Considerations: Where applicable, confirm that the changes do not negatively impact SEO elements.
  • WordPress Coding Standards: Ensure that the code adheres to WordPress coding standards.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • User Acceptance Testing (UAT): If applicable, confirm that stakeholders have reviewed and accepted the changes.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@khleomix khleomix self-assigned this Apr 23, 2024
@khleomix khleomix marked this pull request as ready for review April 25, 2024 17:43
@lswilson lswilson merged commit 51305c2 into main Apr 26, 2024
3 checks passed
@lswilson lswilson deleted the feature/WDSBT-12-Mobile-Menu branch April 26, 2024 14:04
Copy link
Member

@lswilson lswilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khleomix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants