Skip to content

Commit

Permalink
[WPE] Add api-wpe to the EWS status-bubbles
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=264819

Reviewed by Jonathan Bedard and Alexey Proskuryakov.

A new EWS to run WPE API tests was added in 269162@main
The queue has been running fine lately so it is time
to add it to the EWS status-bubbles

This patch also add this queue to the list of Linux-checks
for safe-merge-queue.

* Tools/CISupport/ews-app/ews/common/buildbot.py:
(Buildbot):
* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS):
* Tools/CISupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
* Tools/CISupport/ews-build/steps.py:
(CheckStatusOfPR):

Canonical link: https://commits.webkit.org/270777@main
  • Loading branch information
clopez committed Nov 15, 2023
1 parent 8f58d68 commit 121addd
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 9 deletions.
1 change: 1 addition & 0 deletions Tools/CISupport/ews-app/ews/common/buildbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class Buildbot():
'mac-AS-debug-wk2': 'mac-AS-debug',
'api-gtk': 'gtk',
'gtk-wk2': 'gtk',
'api-wpe': 'wpe',
'wpe-wk2': 'wpe',
'jsc-armv7-tests': 'jsc-armv7',
}
Expand Down
12 changes: 6 additions & 6 deletions Tools/CISupport/ews-app/ews/common/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,12 @@ class GitHubEWS(GitHub):
STATUS_BUBBLE_END = u'<!--EWS-Status-Bubble-End-->'
STATUS_BUBBLE_ROWS = [['style', 'ios', 'mac', 'wpe', 'wincairo'], # FIXME: generate this list dynamically to have merge queue show up on top
['bindings', 'ios-sim', 'mac-AS-debug', 'wpe-wk2', ''],
['webkitperl', 'ios-wk2', 'api-mac', 'gtk', ''],
['webkitpy', 'ios-wk2-wpt', 'mac-wk1', 'gtk-wk2', ''],
['jsc', 'api-ios', 'mac-wk2', 'api-gtk', ''],
['jsc-arm64', 'tv', 'mac-AS-debug-wk2', 'jsc-armv7', ''],
['services', 'tv-sim', 'mac-wk2-stress', 'jsc-armv7-tests', ''],
['merge', 'watch', '', '', ''],
['webkitperl', 'ios-wk2', 'api-mac', 'api-wpe', ''],
['webkitpy', 'ios-wk2-wpt', 'mac-wk1', 'gtk', ''],
['jsc', 'api-ios', 'mac-wk2', 'gtk-wk2', ''],
['jsc-arm64', 'tv', 'mac-AS-debug-wk2', 'api-gtk', ''],
['services', 'tv-sim', 'mac-wk2-stress', 'jsc-armv7', ''],
['merge', 'watch', '', 'jsc-armv7-tests', ''],
['unsafe-merge', 'watch-sim', '', '', '']]

@classmethod
Expand Down
4 changes: 2 additions & 2 deletions Tools/CISupport/ews-app/ews/views/statusbubble.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ class StatusBubble(View):
# FIXME: Auto-generate this list https://bugs.webkit.org/show_bug.cgi?id=195640
# Note: This list is sorted in the order of which bubbles appear in bugzilla.
ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-AS-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo',
'ios-wk2', 'ios-wk2-wpt', 'mac-wk1', 'mac-wk2', 'mac-wk2-stress', 'mac-AS-debug-wk2', 'gtk-wk2', 'wpe-wk2', 'api-ios', 'api-mac', 'api-gtk',
'bindings', 'jsc', 'jsc-arm64', 'jsc-armv7', 'jsc-armv7-tests', 'jsc-i386', 'webkitperl', 'webkitpy', 'services']
'ios-wk2', 'ios-wk2-wpt', 'mac-wk1', 'mac-wk2', 'mac-wk2-stress', 'mac-AS-debug-wk2', 'gtk-wk2', 'wpe-wk2', 'api-ios', 'api-mac',
'api-gtk', 'api-wpe', 'bindings', 'jsc', 'jsc-arm64', 'jsc-armv7', 'jsc-armv7-tests', 'jsc-i386', 'webkitperl', 'webkitpy', 'services']

DAYS_TO_CHECK_QUEUE_POSITION = 0.5
DAYS_TO_HIDE_BUBBLE = 7
Expand Down
2 changes: 1 addition & 1 deletion Tools/CISupport/ews-build/steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -2449,7 +2449,7 @@ class CheckStatusOfPR(buildstep.BuildStep, GitHubMixin, AddToLogMixin):
haltOnFailure = False
EMBEDDED_CHECKS = ['ios', 'ios-sim', 'ios-wk2', 'ios-wk2-wpt', 'api-ios', 'tv', 'tv-sim', 'watch', 'watch-sim']
MACOS_CHECKS = ['mac', 'mac-AS-debug', 'api-mac', 'mac-wk1', 'mac-wk2', 'mac-AS-debug-wk2', 'mac-wk2-stress']
LINUX_CHECKS = ['gtk', 'gtk-wk2', 'api-gtk', 'wpe', 'wpe-wk2']
LINUX_CHECKS = ['gtk', 'gtk-wk2', 'api-gtk', 'wpe', 'wpe-wk2', 'api-wpe']
WINDOWS_CHECKS = ['wincairo']
EWS_WEBKIT_FAILED = 0
EWS_WEBKIT_PASSED = 1
Expand Down

0 comments on commit 121addd

Please sign in to comment.