Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
[ATK] Implement allAttributes() for AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118966 Reviewed by Gustavo Noronha Silva. Tools: Implemented AccessibilityUIElement::allAttributes() both in DumpRenderTree and the WebKitTestRunner. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (getAtkAttributeSetAsString): Moved up in the file, and refactored to use StringBuilder and return a String instead of a gchar*. (roleToString): Changed not to return the "AXRole: " prefix, so we can use it as well from attributesOfElement(). (attributesOfElement): New function to dump attributes for an object. (AccessibilityUIElement::allAttributes): Call attributesOfElement(). (AccessibilityUIElement::role): Updated to prefix "AXRole: ". * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (getAtkAttributeSetAsString): Refactored to use StringBuilder and return a String instead of a gchar*. (WTF::roleToString): Changed not to return the "AXRole: " prefix, so we can use it as well from attributesOfElement(). (WTF::attributesOfElement): New function to dump attributes for an object. (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement(). (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ". LayoutTests: Removed fixed tests from TestExpectations and added/updated expected results for tests that are now dumping more useful information. * platform/gtk/TestExpectations: Removed four fixed tests. * platform/gtk/accessibility/image-link-expected.txt: Updated. * platform/gtk/accessibility/table-cell-spans-expected.txt: Updated * platform/gtk/accessibility/table-cells-expected.txt: Updated * platform/gtk/accessibility/table-detection-expected.txt: Added. * platform/gtk/accessibility/table-one-cell-expected.txt: Added. * platform/gtk/accessibility/table-with-rules-expected.txt: Added. * platform/gtk/accessibility/transformed-element-expected.txt: Added. Canonical link: https://commits.webkit.org/137203@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
12 changed files
with
1,096 additions
and
147 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.