Skip to content

Commit 2317fae

Browse files
committed
imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/evil/media_height_19.html is missing styling in expected file
https://bugs.webkit.org/show_bug.cgi?id=296642 rdar://156717595 Reviewed by Eric Carlson. imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/evil/media_height_19-expected.html is missing html { overflow:hidden } body { margin:0 } Which is causing the video to be positioned differently. All other webvtt rendering tests Have this styling, so it should be added to this one as well. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/evil/media_height_19-expected.html: * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/evil/media_height_19-ref.html: Canonical link: https://commits.webkit.org/298011@main
1 parent e86882a commit 2317fae

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

LayoutTests/TestExpectations

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -631,6 +631,7 @@ imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-mode
631631
imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/embedded_style_selectors.html [ Pass ]
632632
imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/embedded_style_urls.html [ Pass ]
633633
imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/evil/media_404_omit_subtitles.html [ Pass ]
634+
imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/evil/media_height_19.html [ Pass ]
634635

635636
# These WebVTT rendering WPT are flaky.
636637
imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/evil/non-standard-pseudo-elements.html [ ImageOnlyFailure Pass Failure ]

LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/evil/media_height_19-expected.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
<title>Reference for WebVTT rendering, when media height is 19 or less, font size should be smaller than when it is 20 and above</title>
33
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
44
<style>
5+
html { overflow:hidden }
6+
body { margin:0 }
57
.video {
68
display: inline-block;
79
width: 320px;

LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/evil/media_height_19-ref.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
<title>Reference for WebVTT rendering, when media height is 19 or less, font size should be smaller than when it is 20 and above</title>
33
<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
44
<style>
5+
html { overflow:hidden }
6+
body { margin:0 }
57
.video {
68
display: inline-block;
79
width: 320px;

0 commit comments

Comments
 (0)