Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Add support for WebCodecs temporal scalabilityMode for software codecs
https://bugs.webkit.org/show_bug.cgi?id=258076
rdar://110774875

Reviewed by Eric Carlson.

Add WebIDL to expose temporal index on encoded chunks.
Add scalabilityMode enums (L1T1, L1T2 and L1T3) and parsing from string (given by JS) to this enum.
In case parsing fails, we return a TypeError.

Update software encoders to return the temporal index when L1T2 or L1T3 is enabled, as per spec.

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_av1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_av1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any.worker_av1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any.worker_h264_annexb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any.worker_h264_avc-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any_av1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any_h264_annexb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any_h264_avc-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_av1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_h264-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp8-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp9-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any_av1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any_h264-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any_vp8-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any_vp9-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt:
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunkMetadata.h:
* Source/WebCore/Modules/webcodecs/WebCodecsEncodedVideoChunkMetadata.idl:
* Source/WebCore/Modules/webcodecs/WebCodecsSvcOutputMetadata.h: Added.
* Source/WebCore/Modules/webcodecs/WebCodecsSvcOutputMetadata.idl: Added.
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp:
(WebCore::createVideoEncoderConfig):
(WebCore::WebCodecsVideoEncoder::configure):
(WebCore::WebCodecsVideoEncoder::createEncodedChunkMetadata):
(WebCore::WebCodecsVideoEncoder::isConfigSupported):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/VideoEncoder.h:
* Source/WebCore/platform/VideoEncoderScalabilityMode.h: Added.
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:
(WebCore::GStreamerInternalVideoEncoder::GStreamerInternalVideoEncoder):
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp:
(WebCore::LibWebRTCVPXInternalVideoEncoder::initialize):
(WebCore::LibWebRTCVPXInternalVideoEncoder::OnEncodedImage):
* Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp:
(WebKit::RemoteVideoCodecFactory::createEncoder):

Originally-landed-as: 6854c1b. rdar://110774875
Canonical link: https://commits.webkit.org/265561@main
  • Loading branch information
youennf committed Jun 27, 2023
1 parent 2342117 commit 613026d
Show file tree
Hide file tree
Showing 39 changed files with 291 additions and 233 deletions.
@@ -1,4 +1,4 @@

NOTRUN Encoding and decoding cycle Unsupported config: {"codec":"av01.0.04M.08","hasEmbeddedColorSpace":true,"hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30}
NOTRUN Encoding and decoding cycle w/ stripped color space Unsupported config: {"codec":"av01.0.04M.08","hasEmbeddedColorSpace":true,"hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30}
PASS Encoding and decoding cycle
PASS Encoding and decoding cycle w/ stripped color space

@@ -1,4 +1,4 @@

NOTRUN Encoding and decoding cycle Unsupported config: {"codec":"av01.0.04M.08","hasEmbeddedColorSpace":true,"hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30}
NOTRUN Encoding and decoding cycle w/ stripped color space Unsupported config: {"codec":"av01.0.04M.08","hasEmbeddedColorSpace":true,"hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30}
PASS Encoding and decoding cycle
PASS Encoding and decoding cycle w/ stripped color space

@@ -1,3 +1,3 @@

NOTRUN Reconfiguring encoder Unsupported config: {"codec":"av01.0.04M.08","hardwareAcceleration":"prefer-software","bitrateMode":"constant","scalabilityMode":"L1T2","framerate":30,"width":800,"height":600,"bitrate":3000000}
PASS Reconfiguring encoder

@@ -1,3 +1,3 @@

PASS Reconfiguring encoder
NOTRUN Reconfiguring encoder Unsupported config: {"codec":"avc1.42001F","avc":{"format":"annexb"},"hardwareAcceleration":"prefer-software","bitrateMode":"constant","scalabilityMode":"L1T2","framerate":30,"width":800,"height":600,"bitrate":3000000}

@@ -1,3 +1,3 @@

PASS Reconfiguring encoder
NOTRUN Reconfiguring encoder Unsupported config: {"codec":"avc1.42001F","avc":{"format":"avc"},"hardwareAcceleration":"prefer-software","bitrateMode":"constant","scalabilityMode":"L1T2","framerate":30,"width":800,"height":600,"bitrate":3000000}

@@ -1,3 +1,3 @@

NOTRUN Reconfiguring encoder Unsupported config: {"codec":"av01.0.04M.08","hardwareAcceleration":"prefer-software","bitrateMode":"constant","scalabilityMode":"L1T2","framerate":30,"width":800,"height":600,"bitrate":3000000}
PASS Reconfiguring encoder

@@ -1,3 +1,3 @@

PASS Reconfiguring encoder
NOTRUN Reconfiguring encoder Unsupported config: {"codec":"avc1.42001F","avc":{"format":"annexb"},"hardwareAcceleration":"prefer-software","bitrateMode":"constant","scalabilityMode":"L1T2","framerate":30,"width":800,"height":600,"bitrate":3000000}

@@ -1,3 +1,3 @@

PASS Reconfiguring encoder
NOTRUN Reconfiguring encoder Unsupported config: {"codec":"avc1.42001F","avc":{"format":"avc"},"hardwareAcceleration":"prefer-software","bitrateMode":"constant","scalabilityMode":"L1T2","framerate":30,"width":800,"height":600,"bitrate":3000000}

@@ -1,4 +1,4 @@

NOTRUN SVC L1T2 Unsupported config: {"codec":"av01.0.04M.08","hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30,"scalabilityMode":"L1T2"}
NOTRUN SVC L1T3 Unsupported config: {"codec":"av01.0.04M.08","hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30,"scalabilityMode":"L1T3"}
PASS SVC L1T2
PASS SVC L1T3

@@ -1,6 +1,4 @@

Harness Error (FAIL), message = Error in remote https://localhost:9443/resources/testharness.js: Error: assert_own_property: expected property "svc" missing

FAIL SVC L1T2 assert_equals: expected 12 but got 0
FAIL SVC L1T3 assert_equals: expected 6 but got 0
NOTRUN SVC L1T2 Unsupported config: {"codec":"avc1.42001E","avc":{"format":"annexb"},"hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30,"scalabilityMode":"L1T2"}
NOTRUN SVC L1T3 Unsupported config: {"codec":"avc1.42001E","avc":{"format":"annexb"},"hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30,"scalabilityMode":"L1T3"}

@@ -1,6 +1,4 @@

Harness Error (FAIL), message = Error in remote https://localhost:9443/resources/testharness.js: Error: assert_own_property: expected property "svc" missing

FAIL SVC L1T2 assert_equals: expected 12 but got 0
FAIL SVC L1T3 assert_equals: expected 6 but got 0
PASS SVC L1T2
PASS SVC L1T3

@@ -1,6 +1,4 @@

Harness Error (FAIL), message = Error in remote https://localhost:9443/resources/testharness.js: Error: assert_own_property: expected property "svc" missing

FAIL SVC L1T2 assert_equals: expected 12 but got 0
FAIL SVC L1T3 assert_equals: expected 6 but got 0
PASS SVC L1T2
PASS SVC L1T3

@@ -1,4 +1,4 @@

NOTRUN SVC L1T2 Unsupported config: {"codec":"av01.0.04M.08","hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30,"scalabilityMode":"L1T2"}
NOTRUN SVC L1T3 Unsupported config: {"codec":"av01.0.04M.08","hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30,"scalabilityMode":"L1T3"}
PASS SVC L1T2
PASS SVC L1T3

@@ -1,54 +1,4 @@
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing

Harness Error (FAIL), message = Error: assert_own_property: expected property "svc" missing

FAIL SVC L1T2 assert_equals: expected 12 but got 0
FAIL SVC L1T3 assert_equals: expected 6 but got 0
NOTRUN SVC L1T2 Unsupported config: {"codec":"avc1.42001E","avc":{"format":"annexb"},"hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30,"scalabilityMode":"L1T2"}
NOTRUN SVC L1T3 Unsupported config: {"codec":"avc1.42001E","avc":{"format":"annexb"},"hardwareAcceleration":"prefer-software","width":320,"height":200,"bitrate":1000000,"bitrateMode":"constant","framerate":30,"scalabilityMode":"L1T3"}

@@ -1,54 +1,4 @@
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing

Harness Error (FAIL), message = Error: assert_own_property: expected property "svc" missing

FAIL SVC L1T2 assert_equals: expected 12 but got 0
FAIL SVC L1T3 assert_equals: expected 6 but got 0
PASS SVC L1T2
PASS SVC L1T3

@@ -1,54 +1,4 @@
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing
CONSOLE MESSAGE: Error: assert_own_property: expected property "svc" missing

Harness Error (FAIL), message = Error: assert_own_property: expected property "svc" missing

FAIL SVC L1T2 assert_equals: expected 12 but got 0
FAIL SVC L1T3 assert_equals: expected 6 but got 0
PASS SVC L1T2
PASS SVC L1T3

Expand Up @@ -3,7 +3,7 @@ PASS Test that VideoEncoder.isConfigSupported() rejects invalid config:Emtpy cod
PASS Test that VideoEncoder.isConfigSupported() rejects invalid config:Unrecognized codec
FAIL Test that VideoEncoder.isConfigSupported() rejects invalid config:Width is too large assert_unreached: Should have rejected: undefined Reached unreachable code
FAIL Test that VideoEncoder.isConfigSupported() rejects invalid config:Height is too large assert_unreached: Should have rejected: undefined Reached unreachable code
FAIL Test that VideoEncoder.isConfigSupported() rejects invalid config:Invalid scalability mode assert_unreached: Should have rejected: undefined Reached unreachable code
PASS Test that VideoEncoder.isConfigSupported() rejects invalid config:Invalid scalability mode
FAIL VideoEncoder.isConfigSupported() doesn't support config:Too strenuous accelerated encoding parameters assert_false: expected false got true
FAIL VideoEncoder.isConfigSupported() doesn't support config:Odd sized frames for H264 assert_false: expected false got true
PASS VideoEncoder.isConfigSupported() supports:{"codec":"avc1.42001E","hardwareAcceleration":"no-preference","width":640,"height":480,"bitrate":5000000,"framerate":24,"avc":{"format":"annexb"},"futureConfigFeature":"foo"}
Expand Down
Expand Up @@ -3,7 +3,7 @@ PASS Test that VideoEncoder.isConfigSupported() rejects invalid config:Emtpy cod
PASS Test that VideoEncoder.isConfigSupported() rejects invalid config:Unrecognized codec
FAIL Test that VideoEncoder.isConfigSupported() rejects invalid config:Width is too large assert_unreached: Should have rejected: undefined Reached unreachable code
FAIL Test that VideoEncoder.isConfigSupported() rejects invalid config:Height is too large assert_unreached: Should have rejected: undefined Reached unreachable code
FAIL Test that VideoEncoder.isConfigSupported() rejects invalid config:Invalid scalability mode assert_unreached: Should have rejected: undefined Reached unreachable code
PASS Test that VideoEncoder.isConfigSupported() rejects invalid config:Invalid scalability mode
FAIL VideoEncoder.isConfigSupported() doesn't support config:Too strenuous accelerated encoding parameters assert_false: expected false got true
FAIL VideoEncoder.isConfigSupported() doesn't support config:Odd sized frames for H264 assert_false: expected false got true
PASS VideoEncoder.isConfigSupported() supports:{"codec":"avc1.42001E","hardwareAcceleration":"no-preference","width":640,"height":480,"bitrate":5000000,"framerate":24,"avc":{"format":"annexb"},"futureConfigFeature":"foo"}
Expand Down

0 comments on commit 613026d

Please sign in to comment.