You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
export-w3c-test-changes creates duplicate branches instead of updating pre-existing export branch
https://bugs.webkit.org/show_bug.cgi?id=296656
rdar://156960581
Reviewed by Tim Nguyen.
Before 296936@main, the branch name got a suffix if `git show-ref --verify --quiet {branch_name}` == 0.
However, the branch name would never match with the ref since it didn't have the "refs/heads" prefix.
296936@main fixed this by using `branches_for`, but the duplicate branching is actually not what we want.
Having an existing branch get updated with new changes is the desired behaviour, so this PR removes the
logic in `_ensure_new_branch_name` and simply creates a branch name with the `wpt-export-for-webkit-` prefix.
* Tools/Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter._branch_name):
(WebPlatformTestExporter._ensure_wpt_repository):
(WebPlatformTestExporter.create_wpt_pull_request):
(WebPlatformTestExporter._ensure_new_branch_name): Deleted.
Canonical link: https://commits.webkit.org/298053@main
0 commit comments