Skip to content

Commit

Permalink
Wasm Callee should remain set even after tier-up
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=268990
rdar://123015079

Reviewed by Alexey Shvayka.

We may still need to call into the LLInt after tier-up, so we shouldn't clear
callee.

* Source/JavaScriptCore/wasm/WasmCallsiteCollection.cpp:
(JSC::Wasm::CallsiteCollection::updateCallsitesToCallUs):

Canonical link: https://commits.webkit.org/275095@main
  • Loading branch information
Justin Michaud committed Feb 21, 2024
1 parent ed5a44f commit a9c33a2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions LayoutTests/platform/mac/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1216,9 +1216,6 @@ media/modern-media-controls/media-documents/background-color-and-centering.html

webkit.org/b/178083 media/media-source/media-source-paint-to-canvas.html [ Failure ]

webkit.org/b/175102 workers/wasm-hashset-many.html [ Skip ]
webkit.org/b/175102 workers/wasm-hashset-many-2.html [ Skip ]

webkit.org/b/175193 fast/images/async-image-body-background-image.html [ Pass Timeout ]

webkit.org/b/173010 [ Debug ] js/slow-stress/Int32Array-alloc-huge.html [ Pass Timeout ]
Expand Down Expand Up @@ -2575,4 +2572,3 @@ imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-023.svg [ Fail
imported/w3c/web-platform-tests/svg/painting/reftests/percentage-attribute.svg [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/svg/painting/reftests/percentage.svg [ ImageOnlyFailure ]

webkit.org/b/269598 [ Debug ] workers/wasm-hashset.html [ Skip ]
1 change: 0 additions & 1 deletion Source/JavaScriptCore/wasm/WasmCallsiteCollection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ void CallsiteCollection::updateCallsitesToCallUs(const AbstractLocker& calleeGro
WTF::storeStoreFence(); // This probably isn't necessary but it's good to be paranoid.

calleeGroup.m_wasmIndirectCallEntryPoints[functionIndex] = entrypoint;
calleeGroup.m_wasmIndirectCallWasmCallees[functionIndex] = nullptr;

for (auto& callsite : m_callsites[functionIndex]) {
dataLogLnIf(WasmCallsiteCollectionInternal::verbose, "Repatching call at: ", RawPointer(callsite.m_callLocation.dataLocation()), " to ", RawPointer(entrypoint.taggedPtr()));
Expand Down

0 comments on commit a9c33a2

Please sign in to comment.