Skip to content

Commit

Permalink
Disable call to xpc_connection_set_oneshot_instance
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=267368
rdar://120806906

Reviewed by Brent Fulgham.

Disable call to xpc_connection_set_oneshot_instance when launching WebKit processes
as extensions, since this call is not needed, then.

* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::finishLaunchingProcess):

Canonical link: https://commits.webkit.org/273043@main
  • Loading branch information
pvollan committed Jan 15, 2024
1 parent b3fff85 commit af0908f
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ static void launchWithExtensionKit(ProcessLauncher& processLauncher, ProcessLaun

launcher->m_xpcConnection = WTFMove(xpcConnection);
launcher->m_process = WTFMove(process);
if (!launcher->m_xpcConnection) {
NSLog(@"Failed to create XPC connection, error = %@", error);
return;
}
launcher->finishLaunchingProcess(name.characters());
});
};
Expand All @@ -207,7 +211,9 @@ static void launchWithExtensionKit(ProcessLauncher& processLauncher, ProcessLaun
uuid_t uuid;
uuid_generate(uuid);

#if !USE(EXTENSIONKIT)
xpc_connection_set_oneshot_instance(m_xpcConnection.get(), uuid);
#endif

// Inherit UI process localization. It can be different from child process default localization:
// 1. When the application and system frameworks simply have different localized resources available, we should match the application.
Expand Down

0 comments on commit af0908f

Please sign in to comment.