Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http/tests/site-isolation/basic-iframe.html is flaky on iOS #10301

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Feb 17, 2023

f56ebe3

http/tests/site-isolation/basic-iframe.html is flaky on iOS
https://bugs.webkit.org/show_bug.cgi?id=252504

Unreviewed.

Mark the test as flaky on iOS for now, and skip it on Windows like we did Linux.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/260469@main

fb38cae

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios 🛠 mac 🛠 wpe 🛠 wincairo
🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac 🧪 gtk-wk2
🧪 api-ios 🧪 mac-wk1 🧪 api-gtk
🛠 tv 🧪 mac-wk2
✅ 🛠 tv-sim 🧪 mac-AS-debug-wk2
🛠 watch 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@achristensen07 achristensen07 self-assigned this Feb 17, 2023
@achristensen07 achristensen07 added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Feb 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=252504

Unreviewed.

Mark the test as flaky on iOS for now, and skip it on Windows like we did Linux.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/260469@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/httptestssite-isolationbasic-iframe-html-is-flaky-on-iOS branch from fb38cae to f56ebe3 Compare February 17, 2023 22:33
@webkit-commit-queue
Copy link
Collaborator

Committed 260469@main (f56ebe3): https://commits.webkit.org/260469@main

Reviewed commits have been landed. Closing PR #10301 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f56ebe3 into WebKit:main Feb 17, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants