Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Fix trunc trap exception in new Wasm BBQ #10331

Merged
merged 1 commit into from
Feb 18, 2023
Merged

[JSC] Fix trunc trap exception in new Wasm BBQ #10331

merged 1 commit into from
Feb 18, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Feb 18, 2023 •
edited by webkit-early-warning-system
Loading

8067c0f

[JSC] Fix trunc trap exception in new Wasm BBQ
https://bugs.webkit.org/show_bug.cgi?id=252530
rdar://105628911

Reviewed by Mark Lam.

Fix thrown exception type for trunc trapping.

* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::truncTrapping):

Canonical link: https://commits.webkit.org/260515@main

2e39d7a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2   🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2   🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

@Constellation Constellation requested a review from a team as a code owner February 18, 2023 10:53
@Constellation Constellation self-assigned this Feb 18, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Feb 18, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 18, 2023 •
edited
Loading

EWS run on current version of this PR (hash 2e39d7a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2   🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2   🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

MenloDorian
MenloDorian approved these changes Feb 18, 2023
View reviewed changes
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 18, 2023
@Constellation
[JSC] Fix trunc trap exception in new Wasm BBQ
8067c0f 
https://bugs.webkit.org/show_bug.cgi?id=252530
rdar://105628911

Reviewed by Mark Lam.

Fix thrown exception type for trunc trapping.

* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::truncTrapping):

Canonical link: https://commits.webkit.org/260515@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/JSC-Fix-trunc-trap-exception-in-new-Wasm-BBQ branch from 2e39d7a to 8067c0f Compare February 18, 2023 18:07
@webkit-commit-queue
Copy link
Collaborator

Committed 260515@main (8067c0f): https://commits.webkit.org/260515@main

Reviewed commits have been landed. Closing PR #10331 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 8067c0f into WebKit:main Feb 18, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MenloDorian MenloDorian MenloDorian approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @MenloDorian