Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ews-build.webkit.org] Make Contributors.load asynchronous #11975

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Mar 26, 2023

25a06d7

[ews-build.webkit.org] Make Contributors.load asynchronous
https://bugs.webkit.org/show_bug.cgi?id=254470
rdar://107228856

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(GitHub.email_for_owners): Make function asynchronous.
(Contributors.load_from_github): Ditto.
(Contributors.load): Ditto.
(ConfigureBuild.add_pr_details): Invoke Contributors.load as an
asynchronous function.
(ValidateChange.send_email_for_github_failure): Ditto.
(ValidateCommitterAndReviewer.run): Ditto.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):Ditto.
(AddReviewerMixin.gitCommitEnvironment): Make asynchronous function
to invoke Contributors.load as aan asynchronousn function.
(AddReviewerToCommitMessage.run):Invoke gitCommitEnvironment as an
asynchronousn function.
(ValidateCommitMessage.run): Invoke Contributors.load as an
asynchronousn function.
(Canonicalize.run): Ditto.

Canonical link: https://commits.webkit.org/263086@main

1967238

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 🧪 gtk-wk2
🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@JonWBedard JonWBedard self-assigned this Mar 26, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Mar 26, 2023
@JonWBedard JonWBedard force-pushed the eng/ews-build-webkit-org-Make-Contributors-load-asynchronous branch from b48cd05 to 03595b7 Compare March 27, 2023 14:26
@JonWBedard JonWBedard added skip-ews Applied to prevent a change from being run on EWS and removed skip-ews Applied to prevent a change from being run on EWS labels Mar 27, 2023
@JonWBedard JonWBedard force-pushed the eng/ews-build-webkit-org-Make-Contributors-load-asynchronous branch from 03595b7 to c481cf6 Compare March 27, 2023 14:34
@JonWBedard JonWBedard added skip-ews Applied to prevent a change from being run on EWS and removed skip-ews Applied to prevent a change from being run on EWS labels Mar 27, 2023
@JonWBedard JonWBedard force-pushed the eng/ews-build-webkit-org-Make-Contributors-load-asynchronous branch from c481cf6 to 3e1c066 Compare March 29, 2023 17:46
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming this is tested.

@JonWBedard JonWBedard force-pushed the eng/ews-build-webkit-org-Make-Contributors-load-asynchronous branch from 3e1c066 to 1967238 Compare April 18, 2023 16:43
@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 18, 2023
https://bugs.webkit.org/show_bug.cgi?id=254470
rdar://107228856

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(GitHub.email_for_owners): Make function asynchronous.
(Contributors.load_from_github): Ditto.
(Contributors.load): Ditto.
(ConfigureBuild.add_pr_details): Invoke Contributors.load as an
asynchronous function.
(ValidateChange.send_email_for_github_failure): Ditto.
(ValidateCommitterAndReviewer.run): Ditto.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):Ditto.
(AddReviewerMixin.gitCommitEnvironment): Make asynchronous function
to invoke Contributors.load as aan asynchronousn function.
(AddReviewerToCommitMessage.run):Invoke gitCommitEnvironment as an
asynchronousn function.
(ValidateCommitMessage.run): Invoke Contributors.load as an
asynchronousn function.
(Canonicalize.run): Ditto.

Canonical link: https://commits.webkit.org/263086@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/ews-build-webkit-org-Make-Contributors-load-asynchronous branch from 1967238 to 25a06d7 Compare April 18, 2023 18:09
@webkit-commit-queue
Copy link
Collaborator

Committed 263086@main (25a06d7): https://commits.webkit.org/263086@main

Reviewed commits have been landed. Closing PR #11975 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 25a06d7 into WebKit:main Apr 18, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 18, 2023
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Make-Contributors-load-asynchronous branch April 18, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants