-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ews-build.webkit.org] Make Contributors.load asynchronous #11975
[ews-build.webkit.org] Make Contributors.load asynchronous #11975
Conversation
EWS run on previous version of this PR (hash b48cd05) |
b48cd05
to
03595b7
Compare
EWS run on previous version of this PR (hash 03595b7) |
03595b7
to
c481cf6
Compare
EWS run on previous version of this PR (hash c481cf6)
|
c481cf6
to
3e1c066
Compare
EWS run on previous version of this PR (hash 3e1c066) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ assuming this is tested.
3e1c066
to
1967238
Compare
EWS run on current version of this PR (hash 1967238) |
https://bugs.webkit.org/show_bug.cgi?id=254470 rdar://107228856 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (GitHub.email_for_owners): Make function asynchronous. (Contributors.load_from_github): Ditto. (Contributors.load): Ditto. (ConfigureBuild.add_pr_details): Invoke Contributors.load as an asynchronous function. (ValidateChange.send_email_for_github_failure): Ditto. (ValidateCommitterAndReviewer.run): Ditto. (AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto. (AnalyzeLayoutTestsResults.send_email_for_new_test_failures):Ditto. (AddReviewerMixin.gitCommitEnvironment): Make asynchronous function to invoke Contributors.load as aan asynchronousn function. (AddReviewerToCommitMessage.run):Invoke gitCommitEnvironment as an asynchronousn function. (ValidateCommitMessage.run): Invoke Contributors.load as an asynchronousn function. (Canonicalize.run): Ditto. Canonical link: https://commits.webkit.org/263086@main
1967238
to
25a06d7
Compare
Committed 263086@main (25a06d7): https://commits.webkit.org/263086@main Reviewed commits have been landed. Closing PR #11975 and removing active labels. |
25a06d7
1967238
🧪 gtk-wk2🧪 api-ios🧪 mac-AS-debug-wk2