Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ref<> for MatchedProperties::properties instead of RefPtr<> #15724

Merged

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jul 11, 2023

f1c09f6

Use Ref<> for MatchedProperties::properties instead of RefPtr<>
https://bugs.webkit.org/show_bug.cgi?id=259092

Reviewed by Tim Nguyen.

Use Ref<> for MatchedProperties::properties instead of RefPtr<>, to make it
clear it cannot be null.

* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::addElementStyleProperties):
(WebCore::Style::ElementRuleCollector::transferMatchedRules):
(WebCore::Style::ElementRuleCollector::matchAllRules):
(WebCore::Style::ElementRuleCollector::addMatchedProperties):
(WebCore::Style::ElementRuleCollector::addAuthorKeyframeRules):
* Source/WebCore/style/MatchResult.h:
(WebCore::Style::operator==):
(WebCore::Style::add):
* Source/WebCore/style/PageRuleCollector.cpp:
(WebCore::Style::PageRuleCollector::matchPageRules):
* Source/WebCore/style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::addMatch):
(WebCore::Style::PropertyCascade::addImportantMatches):

Canonical link: https://commits.webkit.org/265936@main

77c05f2

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jul 11, 2023
@cdumez cdumez added the CSS Cascading Style Sheets implementation label Jul 11, 2023
@cdumez cdumez requested review from anttijk, mdubet and smfr July 11, 2023 02:50
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Jul 11, 2023
https://bugs.webkit.org/show_bug.cgi?id=259092

Reviewed by Tim Nguyen.

Use Ref<> for MatchedProperties::properties instead of RefPtr<>, to make it
clear it cannot be null.

* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::addElementStyleProperties):
(WebCore::Style::ElementRuleCollector::transferMatchedRules):
(WebCore::Style::ElementRuleCollector::matchAllRules):
(WebCore::Style::ElementRuleCollector::addMatchedProperties):
(WebCore::Style::ElementRuleCollector::addAuthorKeyframeRules):
* Source/WebCore/style/MatchResult.h:
(WebCore::Style::operator==):
(WebCore::Style::add):
* Source/WebCore/style/PageRuleCollector.cpp:
(WebCore::Style::PageRuleCollector::matchPageRules):
* Source/WebCore/style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::addMatch):
(WebCore::Style::PropertyCascade::addImportantMatches):

Canonical link: https://commits.webkit.org/265936@main
@webkit-commit-queue webkit-commit-queue force-pushed the 259092_MatchedProperties_properties branch from 77c05f2 to f1c09f6 Compare July 11, 2023 04:26
@webkit-commit-queue
Copy link
Collaborator

Committed 265936@main (f1c09f6): https://commits.webkit.org/265936@main

Reviewed commits have been landed. Closing PR #15724 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f1c09f6 into WebKit:main Jul 11, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants