-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageBuffer filter operations should return NativeImage #18011
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
kkinnunen-apple:imagebuffer-filter-nativeimage-1
Sep 22, 2023
Merged
ImageBuffer filter operations should return NativeImage #18011
webkit-commit-queue
merged 1 commit into
WebKit:main
from
kkinnunen-apple:imagebuffer-filter-nativeimage-1
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 35a3049)
|
anttijk
approved these changes
Sep 21, 2023
kkinnunen-apple
changed the title
ImageBuffer filter operations should return NativeImage
RemoteImageDecoderAVFProxy leaks video frames through CG image cache
Sep 21, 2023
kkinnunen-apple
force-pushed
the
imagebuffer-filter-nativeimage-1
branch
from
September 21, 2023 10:56
35a3049
to
9f47e6e
Compare
kkinnunen-apple
added
Media
Bugs related to the HTML 5 Media elements.
and removed
Canvas
Bugs related to the canvas element.
labels
Sep 21, 2023
EWS run on previous version of this PR (hash 9f47e6e)
|
kkinnunen-apple
changed the title
RemoteImageDecoderAVFProxy leaks video frames through CG image cache
ImageBuffer filter operations should return NativeImage
Sep 21, 2023
kkinnunen-apple
force-pushed
the
imagebuffer-filter-nativeimage-1
branch
from
September 21, 2023 11:00
9f47e6e
to
35a3049
Compare
kkinnunen-apple
added
Canvas
Bugs related to the canvas element.
and removed
Media
Bugs related to the HTML 5 Media elements.
labels
Sep 21, 2023
kkinnunen-apple
force-pushed
the
imagebuffer-filter-nativeimage-1
branch
from
September 21, 2023 16:31
35a3049
to
5ab53dc
Compare
EWS run on current version of this PR (hash 5ab53dc)
|
kkinnunen-apple
requested review from
shallawa
and removed request for
cdumez
September 21, 2023 19:06
kkinnunen-apple
added
the
merge-queue
Applied to send a pull request to merge-queue
label
Sep 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=261866 rdar://115829020 Reviewed by Antti Koivisto. ImageBuffer operates on NativeImages, WebCore::Image is a higher level type. The filter operations anyway flatten the results into a NativeImage, from which the WebCore::Image was always created. Construct the WebCore::Image at the caller if needed. Since this renames the function, move the GPUP implementation from the RemoteRenderingBackendProxy to the real caller which is the RemoteImageBufferProxy. The messages have already been moved previously. This is work towards simplifying ImageBuffer API use NativeImage only. * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::filteredNativeImage): (WebCore::ImageBuffer::filteredImage): Deleted. * Source/WebCore/platform/graphics/ImageBuffer.h: * Source/WebCore/rendering/style/StyleFilterImage.cpp: (WebCore::StyleFilterImage::image const): * Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp: (WebKit::RemoteImageBuffer::filteredNativeImage): (WebKit::RemoteImageBuffer::getFilteredImage): Deleted. * Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h: * Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.messages.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp: (WebKit::RemoteImageBufferProxy::sendSync): (WebKit::RemoteImageBufferProxy::filteredNativeImage): (WebKit::RemoteImageBufferProxy::filteredImage): Deleted. * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::getFilteredImage): Deleted. * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: Canonical link: https://commits.webkit.org/268301@main
webkit-commit-queue
force-pushed
the
imagebuffer-filter-nativeimage-1
branch
from
September 22, 2023 06:25
5ab53dc
to
f057667
Compare
Committed 268301@main (f057667): https://commits.webkit.org/268301@main Reviewed commits have been landed. Closing PR #18011 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f057667
5ab53dc