[JSC] Create (async) generator object after performing FunctionDeclarationInstantiation #19564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvaikalesh
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash 5109c7b) |
shvaikalesh
force-pushed
the
eng/JSC-Create-async-generator-object-after-performing-FunctionDeclarationInstantiation
branch
from
5109c7b
to
3c7f1d8
Compare
|
EWS run on previous version of this PR (hash 3c7f1d8) |
shvaikalesh
force-pushed
the
eng/JSC-Create-async-generator-object-after-performing-FunctionDeclarationInstantiation
branch
from
3c7f1d8
to
bf215af
Compare
|
EWS run on current version of this PR (hash bf215af) |
shvaikalesh
added
unsafe-merge-queue
…ationInstantiation https://bugs.webkit.org/show_bug.cgi?id=263617 <rdar://problem/117439419> Reviewed by Justin Michaud. initializeDefaultParameterValuesAndSetupFunctionScopeStack(), which implements steps 25-26 of FunctionDeclarationInstantiation [1], may call into arbitrary userland code when evaluating default parameters, affecting the [[Prototype]] of created & returned (async) generator object. With this change, (async) generator object creation happens after parameter initialization, aligning JSC with the spec [1][2] and SpiderMonkey. [1]: https://tc39.es/ecma262/#sec-functiondeclarationinstantiation [2]: https://tc39.es/ecma262/#sec-runtime-semantics-evaluategeneratorbody (step 2) [3]: https://tc39.es/ecma262/#sec-runtime-semantics-evaluateasyncgeneratorbody (step 2) * JSTests/stress/regress-263617.js: Added. * JSTests/test262/expectations.yaml: Mark 8 tests as passing. * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Canonical link: https://commits.webkit.org/269823@main
webkit-commit-queue
force-pushed
the
eng/JSC-Create-async-generator-object-after-performing-FunctionDeclarationInstantiation
branch
from
bf215af
to
d9e5846
Compare
|
Committed 269823@main (d9e5846): https://commits.webkit.org/269823@main Reviewed commits have been landed. Closing PR #19564 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d9e5846
bf215af
🧪 style🛠 ios🛠 mac🛠 wpe🛠 wincairo🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🛠 gtk🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🛠 🧪 jsc🧪 api-ios🧪 mac-wk2🧪 api-gtk🛠 🧪 jsc-arm64🛠 tv🧪 mac-AS-debug-wk2🛠 jsc-armv7🛠 tv-sim🧪 mac-wk2-stress🧪 jsc-armv7-tests🛠 watch🛠 jsc-mips🛠 watch-sim🧪 jsc-mips-tests