[LBSE] Move SVG resources to legacy #19590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash b997400)
|
rwlbuis
changed the title
rwlbuis
force-pushed
the
eng/LBSE-Move-SVG-resources-to-legacy
branch
from
b997400
to
36d03fa
Compare
|
EWS run on current version of this PR (hash 36d03fa)
|
Thanks, but more are needed :) Remember Said wanted to do all in one change. |
Ok, plan is to do them now asap but it does not mean it needs to be one PR, so landing this now. |
https://bugs.webkit.org/show_bug.cgi?id=263722 Reviewed by Nikolas Zimmermann. Move masker/marker to legacy. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/rendering/svg/RenderSVGPath.cpp: (WebCore::markerForType): * Source/WebCore/rendering/svg/RenderSVGShape.cpp: * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp: * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::intersectRepaintRectWithResources): * Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer): (WebCore::writeResources): * Source/WebCore/rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::prepareToRenderSVGContent): * Source/WebCore/rendering/svg/SVGResources.cpp: (WebCore::SVGResources::buildCachedResources): (WebCore::SVGResources::setMarkerStart): (WebCore::SVGResources::setMarkerMid): (WebCore::SVGResources::setMarkerEnd): (WebCore::SVGResources::setMasker): * Source/WebCore/rendering/svg/SVGResources.h: (WebCore::SVGResources::markerStart const): (WebCore::SVGResources::markerMid const): (WebCore::SVGResources::markerEnd const): (WebCore::SVGResources::masker const): * Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp: (WebCore::markerForType): (WebCore::LegacyRenderSVGPath::drawMarkers): (WebCore::LegacyRenderSVGPath::markerRect const): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.cpp: (WebCore::removeFromCacheAndInvalidateDependencies): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMarker.cpp: Renamed from Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp. (WebCore::LegacyRenderSVGResourceMarker::LegacyRenderSVGResourceMarker): (WebCore::LegacyRenderSVGResourceMarker::layout): (WebCore::LegacyRenderSVGResourceMarker::removeAllClientsFromCacheIfNeeded): (WebCore::LegacyRenderSVGResourceMarker::removeClientFromCache): (WebCore::LegacyRenderSVGResourceMarker::applyViewportClip): (WebCore::LegacyRenderSVGResourceMarker::markerBoundaries const): (WebCore::LegacyRenderSVGResourceMarker::localToParentTransform const): (WebCore::LegacyRenderSVGResourceMarker::referencePoint const): (WebCore::LegacyRenderSVGResourceMarker::angle const): (WebCore::LegacyRenderSVGResourceMarker::markerTransformation const): (WebCore::LegacyRenderSVGResourceMarker::draw): (WebCore::LegacyRenderSVGResourceMarker::markerContentTransformation const): (WebCore::LegacyRenderSVGResourceMarker::viewportTransform const): (WebCore::LegacyRenderSVGResourceMarker::calcViewport): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMarker.h: Renamed from Source/WebCore/rendering/svg/RenderSVGResourceMarker.h. * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMarkerInlines.h: Renamed from Source/WebCore/rendering/svg/RenderSVGResourceMarkerInlines.h. (WebCore::LegacyRenderSVGResourceMarker::markerElement const): (WebCore::LegacyRenderSVGResourceMarker::markerUnits const): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.cpp: Renamed from Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp. (WebCore::LegacyRenderSVGResourceMasker::LegacyRenderSVGResourceMasker): (WebCore::LegacyRenderSVGResourceMasker::removeAllClientsFromCacheIfNeeded): (WebCore::LegacyRenderSVGResourceMasker::removeClientFromCache): (WebCore::LegacyRenderSVGResourceMasker::applyResource): (WebCore::LegacyRenderSVGResourceMasker::drawContentIntoMaskImage): (WebCore::LegacyRenderSVGResourceMasker::drawContentIntoContext): (WebCore::LegacyRenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::LegacyRenderSVGResourceMasker::resourceBoundingBox): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.h: Renamed from Source/WebCore/rendering/svg/RenderSVGResourceMasker.h. * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMaskerInlines.h: Renamed from Source/WebCore/rendering/svg/RenderSVGResourceMaskerInlines.h. (WebCore::LegacyRenderSVGResourceMasker::maskElement const): (WebCore::LegacyRenderSVGResourceMasker::maskUnits const): (WebCore::LegacyRenderSVGResourceMasker::maskContentUnits const): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp: * Source/WebCore/svg/SVGElement.cpp: * Source/WebCore/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::createElementRenderer): * Source/WebCore/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::createElementRenderer): * Source/WebCore/svg/graphics/SVGResourceImage.cpp: (WebCore::SVGResourceImage::draw): Canonical link: https://commits.webkit.org/269870@main
webkit-commit-queue
force-pushed
the
eng/LBSE-Move-SVG-resources-to-legacy
branch
from
36d03fa
to
3a242e0
Compare
|
Committed 269870@main (3a242e0): https://commits.webkit.org/269870@main Reviewed commits have been landed. Closing PR #19590 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3a242e0
36d03fa