-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPE] Rename WPEView as WPEWebView #20786
[WPE] Rename WPEView as WPEWebView #20786
Conversation
EWS run on current version of this PR (hash 77f8c38)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about View.h, so it matches the name of the class?
It's not a great name, but it's really confusing when the filename doesn't match the name of the class.
Well, maybe we could rename the class as WPE::WebView later instead. |
https://bugs.webkit.org/show_bug.cgi?id=265191 Reviewed by Don Olmstead. WPEView will conflict with new WPE platform API. * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/API/C/wpe/WKView.cpp: * Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: Renamed from Source/WebKit/UIProcess/API/wpe/WPEView.cpp. (WKWPE::View::View): (WKWPE::m_backend): (WKWPE::View::~View): (WKWPE::View::setClient): (WKWPE::View::frameDisplayed): (WKWPE::View::willStartLoad): (WKWPE::View::didChangePageID): (WKWPE::View::didReceiveUserMessage): (WKWPE::View::webResourceLoadManager): (WKWPE::View::setInputMethodContext): (WKWPE::View::inputMethodContext const): (WKWPE::View::setInputMethodState): (WKWPE::View::selectionDidChange): (WKWPE::View::setSize): (WKWPE::View::setViewState): (WKWPE::View::handleKeyboardEvent): (WKWPE::View::synthesizeCompositionKeyPress): (WKWPE::View::close): (WKWPE::View::setFullScreen): (WKWPE::View::accessible const): (WKWPE::View::platformWebPageProxyForGamepadInput): * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: Renamed from Source/WebKit/UIProcess/API/wpe/WPEView.h. (WKWPE::View::create): (WKWPE::View::page): (WKWPE::View::client const): (WKWPE::View::backend): (WKWPE::View::size const): (WKWPE::View::viewState const): (WKWPE::View::isFullScreen): (WKWPE::View::touchGestureController const): * Source/WebKit/UIProcess/API/wpe/WebKitPopupMenu.cpp: * Source/WebKit/UIProcess/Gamepad/libwpe/UIGamepadProviderLibWPE.cpp: Canonical link: https://commits.webkit.org/271034@main
77f8c38
to
ea7d276
Compare
Committed 271034@main (ea7d276): https://commits.webkit.org/271034@main Reviewed commits have been landed. Closing PR #20786 and removing active labels. |
ea7d276
77f8c38