Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPE] Rename WPEView as WPEWebView #20786

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Nov 21, 2023

ea7d276

[WPE] Rename WPEView as WPEWebView
https://bugs.webkit.org/show_bug.cgi?id=265191

Reviewed by Don Olmstead.

WPEView will conflict with new WPE platform API.

* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/API/C/wpe/WKView.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp:
* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: Renamed from Source/WebKit/UIProcess/API/wpe/WPEView.cpp.
(WKWPE::View::View):
(WKWPE::m_backend):
(WKWPE::View::~View):
(WKWPE::View::setClient):
(WKWPE::View::frameDisplayed):
(WKWPE::View::willStartLoad):
(WKWPE::View::didChangePageID):
(WKWPE::View::didReceiveUserMessage):
(WKWPE::View::webResourceLoadManager):
(WKWPE::View::setInputMethodContext):
(WKWPE::View::inputMethodContext const):
(WKWPE::View::setInputMethodState):
(WKWPE::View::selectionDidChange):
(WKWPE::View::setSize):
(WKWPE::View::setViewState):
(WKWPE::View::handleKeyboardEvent):
(WKWPE::View::synthesizeCompositionKeyPress):
(WKWPE::View::close):
(WKWPE::View::setFullScreen):
(WKWPE::View::accessible const):
(WKWPE::View::platformWebPageProxyForGamepadInput):
* Source/WebKit/UIProcess/API/wpe/WPEWebView.h: Renamed from Source/WebKit/UIProcess/API/wpe/WPEView.h.
(WKWPE::View::create):
(WKWPE::View::page):
(WKWPE::View::client const):
(WKWPE::View::backend):
(WKWPE::View::size const):
(WKWPE::View::viewState const):
(WKWPE::View::isFullScreen):
(WKWPE::View::touchGestureController const):
* Source/WebKit/UIProcess/API/wpe/WebKitPopupMenu.cpp:
* Source/WebKit/UIProcess/Gamepad/libwpe/UIGamepadProviderLibWPE.cpp:

Canonical link: https://commits.webkit.org/271034@main

77f8c38

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@carlosgcampos carlosgcampos self-assigned this Nov 21, 2023
@carlosgcampos carlosgcampos added the WPE WebKit WebKit WPE component label Nov 21, 2023
Copy link
Contributor

@mcatanzaro mcatanzaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about View.h, so it matches the name of the class?

It's not a great name, but it's really confusing when the filename doesn't match the name of the class.

@carlosgcampos
Copy link
Contributor Author

Well, maybe we could rename the class as WPE::WebView later instead.

@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=265191

Reviewed by Don Olmstead.

WPEView will conflict with new WPE platform API.

* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/API/C/wpe/WKView.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp:
* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: Renamed from Source/WebKit/UIProcess/API/wpe/WPEView.cpp.
(WKWPE::View::View):
(WKWPE::m_backend):
(WKWPE::View::~View):
(WKWPE::View::setClient):
(WKWPE::View::frameDisplayed):
(WKWPE::View::willStartLoad):
(WKWPE::View::didChangePageID):
(WKWPE::View::didReceiveUserMessage):
(WKWPE::View::webResourceLoadManager):
(WKWPE::View::setInputMethodContext):
(WKWPE::View::inputMethodContext const):
(WKWPE::View::setInputMethodState):
(WKWPE::View::selectionDidChange):
(WKWPE::View::setSize):
(WKWPE::View::setViewState):
(WKWPE::View::handleKeyboardEvent):
(WKWPE::View::synthesizeCompositionKeyPress):
(WKWPE::View::close):
(WKWPE::View::setFullScreen):
(WKWPE::View::accessible const):
(WKWPE::View::platformWebPageProxyForGamepadInput):
* Source/WebKit/UIProcess/API/wpe/WPEWebView.h: Renamed from Source/WebKit/UIProcess/API/wpe/WPEView.h.
(WKWPE::View::create):
(WKWPE::View::page):
(WKWPE::View::client const):
(WKWPE::View::backend):
(WKWPE::View::size const):
(WKWPE::View::viewState const):
(WKWPE::View::isFullScreen):
(WKWPE::View::touchGestureController const):
* Source/WebKit/UIProcess/API/wpe/WebKitPopupMenu.cpp:
* Source/WebKit/UIProcess/Gamepad/libwpe/UIGamepadProviderLibWPE.cpp:

Canonical link: https://commits.webkit.org/271034@main
@webkit-commit-queue
Copy link
Collaborator

Committed 271034@main (ea7d276): https://commits.webkit.org/271034@main

Reviewed commits have been landed. Closing PR #20786 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ea7d276 into WebKit:main Nov 22, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 22, 2023
@carlosgcampos carlosgcampos deleted the wpe-web-view-rename branch November 22, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WPE WebKit WebKit WPE component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants