Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate serialization for WebCore::Payment, WebCore::PaymentContact, and WebCore::PaymentMerchantSession #22916

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Generate serialization for WebCore::Payment, WebCore::PaymentContact, and WebCore::PaymentMerchantSession #22916

merged 1 commit into from
Jan 25, 2024

Conversation

sheeparegreat
Copy link
Contributor

@sheeparegreat sheeparegreat commented Jan 18, 2024 •
edited by webkit-early-warning-system
Loading

2a16c10

Generate serialization for WebCore::Payment, WebCore::PaymentContact, and WebCore::PaymentMerchantSession
https://bugs.webkit.org/show_bug.cgi?id=267703
rdar://121195605

Reviewed by Alex Christensen.

* Source/WebCore/Modules/applepay/Payment.h:
* Source/WebCore/Modules/applepay/PaymentContact.h:
* Source/WebCore/Modules/applepay/PaymentMerchantSession.h:
(WebCore::PaymentMerchantSession::pkPaymentMerchantSession const):
* Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm:
(WebCore::Payment::pkPayment const):
* Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm:
(WebCore::PaymentContact::pkContact const):
* Source/WebCore/testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::showPaymentUI):
* Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm:
(WebKit::PaymentAuthorizationPresenter::completeMerchantValidation):
* Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest):
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::getClass<PKPayment>): Deleted.
(IPC::getClass<PKPaymentMerchantSession>): Deleted.
(IPC::getClass<PKPaymentMethod>): Deleted.
(IPC::ArgumentCoder<WebCore::Payment>::encode): Deleted.
(IPC::ArgumentCoder<WebCore::Payment>::decode): Deleted.
(IPC::ArgumentCoder<WebCore::PaymentContact>::encode): Deleted.
(IPC::ArgumentCoder<WebCore::PaymentContact>::decode): Deleted.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::encode): Deleted.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::decode): Deleted.
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.h:

Canonical link: https://commits.webkit.org/273512@main

4dc79c5

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@sheeparegreat sheeparegreat self-assigned this Jan 18, 2024
@sheeparegreat sheeparegreat added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Jan 18, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 18, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 7269c15)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

aprotyas
aprotyas reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@aprotyas aprotyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sheeparegreat sheeparegreat force-pushed the eng/Generate-serialization-for-WebCorePayment-WebCorePaymentContact-and-WebCorePaymentMerchantSession branch from 7269c15 to aee28a8 Compare January 22, 2024 22:33
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 22, 2024 •
edited
Loading

EWS run on previous version of this PR (hash aee28a8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@sheeparegreat sheeparegreat force-pushed the eng/Generate-serialization-for-WebCorePayment-WebCorePaymentContact-and-WebCorePaymentMerchantSession branch from aee28a8 to 4dc79c5 Compare January 25, 2024 05:05
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 25, 2024 •
edited
Loading

EWS run on current version of this PR (hash 4dc79c5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 25, 2024
@sheeparegreat @achristensen07
Generate serialization for WebCore::Payment, WebCore::PaymentContact,…
2a16c10 
… and WebCore::PaymentMerchantSession

https://bugs.webkit.org/show_bug.cgi?id=267703
rdar://121195605

Reviewed by Alex Christensen.

* Source/WebCore/Modules/applepay/Payment.h:
* Source/WebCore/Modules/applepay/PaymentContact.h:
* Source/WebCore/Modules/applepay/PaymentMerchantSession.h:
(WebCore::PaymentMerchantSession::pkPaymentMerchantSession const):
* Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm:
(WebCore::Payment::pkPayment const):
* Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm:
(WebCore::PaymentContact::pkContact const):
* Source/WebCore/testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::showPaymentUI):
* Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm:
(WebKit::PaymentAuthorizationPresenter::completeMerchantValidation):
* Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest):
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::getClass<PKPayment>): Deleted.
(IPC::getClass<PKPaymentMerchantSession>): Deleted.
(IPC::getClass<PKPaymentMethod>): Deleted.
(IPC::ArgumentCoder<WebCore::Payment>::encode): Deleted.
(IPC::ArgumentCoder<WebCore::Payment>::decode): Deleted.
(IPC::ArgumentCoder<WebCore::PaymentContact>::encode): Deleted.
(IPC::ArgumentCoder<WebCore::PaymentContact>::decode): Deleted.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::encode): Deleted.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::decode): Deleted.
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.h:

Canonical link: https://commits.webkit.org/273512@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Generate-serialization-for-WebCorePayment-WebCorePaymentContact-and-WebCorePaymentMerchantSession branch from 4dc79c5 to 2a16c10 Compare January 25, 2024 17:36
@webkit-commit-queue
Copy link
Collaborator

Committed 273512@main (2a16c10): https://commits.webkit.org/273512@main

Reviewed commits have been landed. Closing PR #22916 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2a16c10 into WebKit:main Jan 25, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprotyas aprotyas aprotyas left review comments

@achristensen07 achristensen07 achristensen07 approved these changes

Assignees

@sheeparegreat sheeparegreat

Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sheeparegreat @webkit-early-warning-system @webkit-commit-queue @achristensen07 @aprotyas