Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove :-khtml-drag pseudo-class alias #23012

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jan 20, 2024

157eda4

Remove `:-khtml-drag` pseudo-class alias
https://bugs.webkit.org/show_bug.cgi?id=267805
rdar://121303391

Reviewed by Anne van Kesteren.

Chrome has unshipped this for a while, let's give it a try. Firefox has never shipped this.

A quick Github search for `:-khtml-drag` shows a small number of hits: https://github.com/search?q=%3A-khtml-drag&;type=code

- Styling for dragging elements will change for the few sites that were using this.
- None of the hits are using `:-khtml-drag` in a selector list, which means this change wouldn't accidentally un-apply declarations for a different selector

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos.html:
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/process-css-pseudo-selectors.py:
(InputValidator.validate_fields.is_known_prefix):

Canonical link: https://commits.webkit.org/273261@main

7879ccc

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m self-assigned this Jan 20, 2024
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Jan 20, 2024
@nt1m nt1m added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jan 20, 2024
https://bugs.webkit.org/show_bug.cgi?id=267805
rdar://121303391

Reviewed by Anne van Kesteren.

Chrome has unshipped this for a while, let's give it a try. Firefox has never shipped this.

A quick Github search for `:-khtml-drag` shows a small number of hits: https://github.com/search?q=%3A-khtml-drag&type=code

- Styling for dragging elements will change for the few sites that were using this.
- None of the hits are using `:-khtml-drag` in a selector list, which means this change wouldn't accidentally un-apply declarations for a different selector

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos.html:
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/process-css-pseudo-selectors.py:
(InputValidator.validate_fields.is_known_prefix):

Canonical link: https://commits.webkit.org/273261@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove--khtml-drag-pseudo-class-alias branch from 7879ccc to 157eda4 Compare January 20, 2024 10:36
@webkit-commit-queue
Copy link
Collaborator

Committed 273261@main (157eda4): https://commits.webkit.org/273261@main

Reviewed commits have been landed. Closing PR #23012 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 157eda4 into WebKit:main Jan 20, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 20, 2024
@nt1m nt1m deleted the eng/Remove--khtml-drag-pseudo-class-alias branch January 20, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants