Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Enumtraits<> from WebKit/Shared/Extensions/ #23516

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Remove Enumtraits<> from WebKit/Shared/Extensions/ #23516

merged 1 commit into from
Jan 31, 2024

Conversation

mikhailramalho
Copy link
Contributor

@mikhailramalho mikhailramalho commented Jan 30, 2024 •
edited by webkit-early-warning-system
Loading

5495e9f

Remove Enumtraits<> from WebKit/Shared/Extensions/
https://bugs.webkit.org/show_bug.cgi?id=268383

Reviewed by Timothy Hatcher.

The enums already use the new serialization format and are defined
in WebExtensionStorage.serialization.in

* Source/WebKit/Shared/Extensions/WebExtensionStorageAccessLevel.h:
* Source/WebKit/Shared/Extensions/WebExtensionStorageType.h:

Canonical link: https://commits.webkit.org/273825@main

0cd9d9d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mikhailramalho mikhailramalho self-assigned this Jan 30, 2024
@mikhailramalho mikhailramalho added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jan 30, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 30, 2024 •
edited
Loading

EWS run on current version of this PR (hash 0cd9d9d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mikhailramalho mikhailramalho added the merge-queue Applied to send a pull request to merge-queue label Jan 31, 2024
@mikhailramalho
Remove Enumtraits<> from WebKit/Shared/Extensions/
5495e9f 
https://bugs.webkit.org/show_bug.cgi?id=268383

Reviewed by Timothy Hatcher.

The enums already use the new serialization format and are defined
in WebExtensionStorage.serialization.in

* Source/WebKit/Shared/Extensions/WebExtensionStorageAccessLevel.h:
* Source/WebKit/Shared/Extensions/WebExtensionStorageType.h:

Canonical link: https://commits.webkit.org/273825@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-Enumtraits-from-WebKitSharedExtensions branch from 0cd9d9d to 5495e9f Compare January 31, 2024 13:57
@webkit-commit-queue webkit-commit-queue merged commit 5495e9f into WebKit:main Jan 31, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 273825@main (5495e9f): https://commits.webkit.org/273825@main

Reviewed commits have been landed. Closing PR #23516 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 31, 2024
@mikhailramalho mikhailramalho deleted the eng/Remove-Enumtraits-from-WebKitSharedExtensions branch February 9, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeenon xeenon xeenon approved these changes

@b-weinstein b-weinstein Awaiting requested review from b-weinstein b-weinstein is a code owner

Assignees

@mikhailramalho mikhailramalho

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikhailramalho @webkit-early-warning-system @webkit-commit-queue @xeenon