Remove runtime check for using extensions when USE(EXTENSIONKIT) is true #24030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
WebKit Process Model
achristensen07
force-pushed
the
eng/Remove-runtime-check-for-using-extensions-when-USEEXTENSIONKIT-is-true
branch
2 times, most recently
from
a5fc08e
to
f871acf
Compare
|
EWS run on previous version of this PR (hash 5b26bab)
|
|
EWS run on previous version of this PR (hash a5fc08e)
|
|
EWS run on previous version of this PR (hash f871acf)
|
webkit-ews-buildbot
added
the
merging-blocked
achristensen07
removed
the
merging-blocked
achristensen07
force-pushed
the
eng/Remove-runtime-check-for-using-extensions-when-USEEXTENSIONKIT-is-true
branch
from
f871acf
to
2b38528
Compare
|
EWS run on current version of this PR (hash 2b38528)
|
achristensen07
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=268944 Reviewed by Per Arne Vollan. The runtime check is no longer needed. This also fixes some issues when you use a WKWebsiteDataStore and the network process before a WKProcessPool has been allocated. * Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: (WebKit::AuxiliaryProcessProxy::setManageProcessesAsExtensions): Deleted. (WebKit::AuxiliaryProcessProxy::manageProcessesAsExtensions): Deleted. * Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm: (WebKit::AuxiliaryProcessProxy::platformGetLaunchOptions): * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::updateMediaCapability): * Source/WebKit/UIProcess/WebProcessPool.cpp: * Source/WebKit/UIProcess/ios/WKContentView.mm: (-[WKContentView _setupVisibilityPropagationForWebProcess]): (-[WKContentView _setupVisibilityPropagationForGPUProcess]): (-[WKContentView _createVisibilityPropagationView]): Canonical link: https://commits.webkit.org/274267@main
webkit-commit-queue
force-pushed
the
eng/Remove-runtime-check-for-using-extensions-when-USEEXTENSIONKIT-is-true
branch
from
2b38528
to
a869bc0
Compare
|
Committed 274267@main (a869bc0): https://commits.webkit.org/274267@main Reviewed commits have been landed. Closing PR #24030 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a869bc0
2b38528
🛠 wincairo🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🛠 watch