-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove runtime check for using extensions when USE(EXTENSIONKIT) is true #24030
Remove runtime check for using extensions when USE(EXTENSIONKIT) is true #24030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! R=me.
a5fc08e
to
f871acf
Compare
EWS run on previous version of this PR (hash 5b26bab)
|
EWS run on previous version of this PR (hash a5fc08e)
|
EWS run on previous version of this PR (hash f871acf)
|
f871acf
to
2b38528
Compare
EWS run on current version of this PR (hash 2b38528)
|
https://bugs.webkit.org/show_bug.cgi?id=268944 Reviewed by Per Arne Vollan. The runtime check is no longer needed. This also fixes some issues when you use a WKWebsiteDataStore and the network process before a WKProcessPool has been allocated. * Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: (WebKit::AuxiliaryProcessProxy::setManageProcessesAsExtensions): Deleted. (WebKit::AuxiliaryProcessProxy::manageProcessesAsExtensions): Deleted. * Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm: (WebKit::AuxiliaryProcessProxy::platformGetLaunchOptions): * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::updateMediaCapability): * Source/WebKit/UIProcess/WebProcessPool.cpp: * Source/WebKit/UIProcess/ios/WKContentView.mm: (-[WKContentView _setupVisibilityPropagationForWebProcess]): (-[WKContentView _setupVisibilityPropagationForGPUProcess]): (-[WKContentView _createVisibilityPropagationView]): Canonical link: https://commits.webkit.org/274267@main
2b38528
to
a869bc0
Compare
Committed 274267@main (a869bc0): https://commits.webkit.org/274267@main Reviewed commits have been landed. Closing PR #24030 and removing active labels. |
a869bc0
2b38528
🛠 wincairo🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🛠 watch