Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of downcast>() in ScopedEventQueue::enqueueEvent() #25358

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Get rid of downcast>() in ScopedEventQueue::enqueueEvent() #25358

merged 1 commit into from
Mar 1, 2024

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Mar 1, 2024 •
edited by webkit-early-warning-system
Loading

81d1596

Get rid of downcast>() in ScopedEventQueue::enqueueEvent()
https://bugs.webkit.org/show_bug.cgi?id=270371

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchScopedEvent):
* Source/WebCore/dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::enqueueEvent):
* Source/WebCore/dom/ScopedEventQueue.h:

Canonical link: https://commits.webkit.org/275576@main

c29934e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez requested a review from rniwa as a code owner March 1, 2024 20:18
@cdumez cdumez self-assigned this Mar 1, 2024
@cdumez cdumez added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Mar 1, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 1, 2024 •
edited
Loading

EWS run on current version of this PR (hash c29934e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 1, 2024
@cdumez
Get rid of downcast>() in ScopedEventQueue::enqueueEvent()
81d1596 
https://bugs.webkit.org/show_bug.cgi?id=270371

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchScopedEvent):
* Source/WebCore/dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::enqueueEvent):
* Source/WebCore/dom/ScopedEventQueue.h:

Canonical link: https://commits.webkit.org/275576@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275576@main (81d1596): https://commits.webkit.org/275576@main

Reviewed commits have been landed. Closing PR #25358 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 81d1596 into WebKit:main Mar 1, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

Assignees

@cdumez cdumez

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @rniwa