Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iPhone 7 from run-webkit-tests simulator testing. #25641

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

bls1999
Copy link
Contributor

@bls1999 bls1999 commented Mar 8, 2024

88f3f50

Remove iPhone 7 from run-webkit-tests simulator testing.
https://bugs.webkit.org/show_bug.cgi?id=270708
rdar://124253881

Reviewed by Ryan Haddad.

run-webkit-tests will check for the existence of iPhone 7-specific test expectations as one of its steps. As we have not tested on iPhone 7 simulators for many years, this PR removes that call.

* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Removed iPhone 7 device configuration presence unit test.
(RunTest.test_device_type_test_division): Removed iPhone 7 device configuration presence unit test.
(RunTest.test_device_type_specific_listing): Removed iPhone 7 device configuration presence unit test.
* Tools/Scripts/webkitpy/port/ios_simulator.py: Removed iPhone 7 device configuration.
(IOSSimulatorPort): Removed iPhone 7 device configuration.
(IPhoneSimulatorPort): Removed iPhone 7 device configuration.

Canonical link: https://commits.webkit.org/275871@main

061f649

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@bls1999 bls1999 self-assigned this Mar 8, 2024
@bls1999 bls1999 requested a review from JonWBedard as a code owner March 8, 2024 20:00
@bls1999 bls1999 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Mar 8, 2024
@ryanhaddad
Copy link
Contributor

There are a few more references to this device in Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py that will need to be fixed up for webkitpy tests to pass.

@bls1999
Copy link
Contributor Author

bls1999 commented Mar 8, 2024

There are a few more references to this device in Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py that will need to be fixed up for webkitpy tests to pass.

On it! Thanks

@bls1999 bls1999 added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 9, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Failed gtk, gtk-wk2 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #25641 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 9, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #14398.

@bls1999 bls1999 added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Mar 9, 2024
https://bugs.webkit.org/show_bug.cgi?id=270708
rdar://124253881

Reviewed by Ryan Haddad.

run-webkit-tests will check for the existence of iPhone 7-specific test expectations as one of its steps. As we have not tested on iPhone 7 simulators for many years, this PR removes that call.

* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Removed iPhone 7 device configuration presence unit test.
(RunTest.test_device_type_test_division): Removed iPhone 7 device configuration presence unit test.
(RunTest.test_device_type_specific_listing): Removed iPhone 7 device configuration presence unit test.
* Tools/Scripts/webkitpy/port/ios_simulator.py: Removed iPhone 7 device configuration.
(IOSSimulatorPort): Removed iPhone 7 device configuration.
(IPhoneSimulatorPort): Removed iPhone 7 device configuration.

Canonical link: https://commits.webkit.org/275871@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275871@main (88f3f50): https://commits.webkit.org/275871@main

Reviewed commits have been landed. Closing PR #25641 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 88f3f50 into WebKit:main Mar 9, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants