-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove iPhone 7 from run-webkit-tests simulator testing. #25641
Conversation
EWS run on previous version of this PR (hash 0188aa4)
|
There are a few more references to this device in |
On it! Thanks |
EWS run on previous version of this PR (hash 3ae8f3c) |
EWS run on previous version of this PR (hash 0d12d06)
|
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
Outdated
Show resolved
Hide resolved
EWS run on current version of this PR (hash 061f649) |
Failed gtk, gtk-wk2 checks. Please resolve failures and re-apply Rejecting #25641 from merge queue. |
Safe-Merge-Queue: Build #14398. |
https://bugs.webkit.org/show_bug.cgi?id=270708 rdar://124253881 Reviewed by Ryan Haddad. run-webkit-tests will check for the existence of iPhone 7-specific test expectations as one of its steps. As we have not tested on iPhone 7 simulators for many years, this PR removes that call. * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Removed iPhone 7 device configuration presence unit test. (RunTest.test_device_type_test_division): Removed iPhone 7 device configuration presence unit test. (RunTest.test_device_type_specific_listing): Removed iPhone 7 device configuration presence unit test. * Tools/Scripts/webkitpy/port/ios_simulator.py: Removed iPhone 7 device configuration. (IOSSimulatorPort): Removed iPhone 7 device configuration. (IPhoneSimulatorPort): Removed iPhone 7 device configuration. Canonical link: https://commits.webkit.org/275871@main
061f649
to
88f3f50
Compare
Committed 275871@main (88f3f50): https://commits.webkit.org/275871@main Reviewed commits have been landed. Closing PR #25641 and removing active labels. |
88f3f50
061f649