Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isTestServerTrust() in ServiceWorkerBasic.mm should use WTF::bridge_cast<> #29059

Merged
merged 1 commit into from
May 25, 2024
Merged

isTestServerTrust() in ServiceWorkerBasic.mm should use WTF::bridge_cast<> #29059

merged 1 commit into from
May 25, 2024

Conversation

ddkilzer
Copy link
Contributor

@ddkilzer ddkilzer commented May 24, 2024 •
edited by webkit-early-warning-system
Loading

90640da

isTestServerTrust() in ServiceWorkerBasic.mm should use WTF::bridge_cast<>
<https://bugs.webkit.org/show_bug.cgi?id=274659>
<rdar://128686657>

Reviewed by Darin Adler.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- Switch from adoptNS() to adoptCF().get(), and use
  WTF::bridge_cast<>() instead of (NSString *) to toll-free bridge the
  CFStringRef to NSString.

Canonical link: https://commits.webkit.org/279307@main

192e5af

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@ddkilzer ddkilzer self-assigned this May 24, 2024
@ddkilzer ddkilzer added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 24, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 24, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 1d8a9ce)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
  🛠 watch
✅ 🛠 watch-sim

@ddkilzer ddkilzer force-pushed the eng/isTestServerTrust-in-ServiceWorkerBasic-mm-should-use-WTFbridge_cast branch from 1d8a9ce to 192e5af Compare May 24, 2024 18:43
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 24, 2024 •
edited
Loading

EWS run on current version of this PR (hash 192e5af)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@ddkilzer ddkilzer added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 25, 2024
@ddkilzer
isTestServerTrust() in ServiceWorkerBasic.mm should use WTF::bridge_c…
90640da 
…ast<>

<https://bugs.webkit.org/show_bug.cgi?id=274659>
<rdar://128686657>

Reviewed by Darin Adler.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- Switch from adoptNS() to adoptCF().get(), and use
  WTF::bridge_cast<>() instead of (NSString *) to toll-free bridge the
  CFStringRef to NSString.

Canonical link: https://commits.webkit.org/279307@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/isTestServerTrust-in-ServiceWorkerBasic-mm-should-use-WTFbridge_cast branch from 192e5af to 90640da Compare May 25, 2024 03:27
@webkit-commit-queue
Copy link
Collaborator

Committed 279307@main (90640da): https://commits.webkit.org/279307@main

Reviewed commits have been landed. Closing PR #29059 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 90640da into WebKit:main May 25, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 25, 2024
@ddkilzer ddkilzer deleted the eng/isTestServerTrust-in-ServiceWorkerBasic-mm-should-use-WTFbridge_cast branch May 25, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@achristensen07 achristensen07 Awaiting requested review from achristensen07

Assignees

@ddkilzer ddkilzer

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddkilzer @webkit-early-warning-system @webkit-commit-queue @darinadler