_WKWebExtensionSQLiteStore object is being deallocated before extension storage is removed #29234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash a3efce9) |
🧪 api-gtk
xeenon
approved these changes
May 29, 2024
b-weinstein
approved these changes
May 29, 2024
kiaraarose
added
safe-merge-queue
…on storage is removed https://bugs.webkit.org/show_bug.cgi?id=274850 rdar://128907598 Reviewed by Timothy Hatcher and Brian Weinstein. In Release builds, the _WKWebExtensionSQLiteStore object being used to remove extension storage is being deallocated before we make the call to remove the extension data. To prevent this from happening, don't use weakSelf in `deleteDatabaseWithCompletionHandler` to keep the object alive longer. * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm: (-[_WKWebExtensionSQLiteStore deleteDatabaseWithCompletionHandler:]): Canonical link: https://commits.webkit.org/279465@main
webkit-commit-queue
force-pushed
the
eng/Deleting-Extension-Storage-Fails-In-Release-Builds
branch
from
a3efce9
to
0d9af47
Compare
|
Committed 279465@main (0d9af47): https://commits.webkit.org/279465@main Reviewed commits have been landed. Closing PR #29234 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0d9af47
a3efce9
🧪 wpe-wk2🧪 api-ios🧪 mac-wk2-stress🛠 watch